Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): fix invalid vector access #4253

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jul 12, 2023

Description

Fix invalid vector access. 🙏

Tests performed

Psim

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 12, 2023
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota enabled auto-merge (squash) July 12, 2023 05:52
@satoshi-ota
Copy link
Contributor Author

🙏

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (6bf539b) 15.21% compared to head (ae2352c) 15.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4253      +/-   ##
==========================================
+ Coverage   15.21%   15.22%   +0.01%     
==========================================
  Files        1489     1489              
  Lines      102611   102543      -68     
  Branches    31524    31513      -11     
==========================================
  Hits        15611    15611              
+ Misses      70048    69979      -69     
- Partials    16952    16953       +1     
Flag Coverage Δ *Carryforward flag
differential 13.67% <0.00%> (?)
total 15.22% <ø> (+0.01%) ⬆️ Carriedforward from 6bf539b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ed_object_validation/src/object_lanelet_filter.cpp 0.00% <ø> (ø)
...dation/src/obstacle_pointcloud_based_validator.cpp 0.00% <ø> (ø)
..._validation/src/occupancy_grid_based_validator.cpp 0.00% <ø> (ø)
...ction_by_tracker/src/detection_by_tracker_core.cpp 0.00% <ø> (ø)
...heatmap_visualizer/src/heatmap_visualizer_node.cpp 0.00% <ø> (ø)
...ulti_object_tracker/tracker/model/tracker_base.hpp 0.00% <ø> (ø)
..._tracker/src/data_association/data_association.cpp 0.00% <ø> (ø)
...i_object_tracker/src/multi_object_tracker_core.cpp 0.00% <ø> (ø)
...ject_tracker/src/tracker/model/bicycle_tracker.cpp 0.00% <ø> (ø)
..._tracker/src/tracker/model/big_vehicle_tracker.cpp 0.00% <ø> (ø)
... and 23 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota merged commit 67c95e9 into autowarefoundation:main Jul 12, 2023
@satoshi-ota satoshi-ota deleted the fix/invalid-access branch July 12, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants