Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(route_handler): improve warning message #4252

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Jul 12, 2023

Description

Add a warning message when the route plan is failed. Now it sometimes fails without any information nor warnings.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe enabled auto-merge (squash) July 12, 2023 05:25
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 12, 2023
Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for mission_planner package.

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6bf539b) 15.21% compared to head (9959678) 15.21%.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #4252    +/-   ##
========================================
  Coverage   15.21%   15.21%            
========================================
  Files        1489     1489            
  Lines      102611   103383   +772     
  Branches    31524    32089   +565     
========================================
+ Hits        15611    15730   +119     
- Misses      70048    70575   +527     
- Partials    16952    17078   +126     
Flag Coverage Δ *Carryforward flag
differential 16.25% <0.00%> (?)
total 15.21% <ø> (+<0.01%) ⬆️ Carriedforward from 6bf539b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ne_module/lane_change/avoidance_by_lane_change.cpp 0.00% <0.00%> (ø)
...n_planner/src/lanelet2_plugins/default_planner.cpp 22.00% <0.00%> (-0.11%) ⬇️
planning/route_handler/src/route_handler.cpp 24.80% <0.00%> (+<0.01%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TakaHoribe TakaHoribe merged commit a369e5a into autowarefoundation:main Jul 12, 2023
@TakaHoribe TakaHoribe deleted the route-debug-msg branch July 12, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants