Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run_out): clear stop pose to prevent virtual wall from remaining #4240

Merged

Conversation

TomohitoAndo
Copy link
Contributor

@TomohitoAndo TomohitoAndo commented Jul 11, 2023

Description

Virtual wall marker of run out module didn't disappear because the deletion of stop pose was removed here.
https://github.com/autowarefoundation/autoware.universe/pull/3851/files#diff-530cf815b1cfc7b84fa40747b0dff416310bfd62b2c2530483b190a122fb9456L186

simplescreenrecorder-2023-07-11_14.42.35.mp4

Tests performed

I tested on a simple planning simulator.

simplescreenrecorder-2023-07-11_15.16.48.mp4

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomohitoAndo
Copy link
Contributor Author

TomohitoAndo commented Jul 11, 2023

@mkuri
Could you approve this PR as a codeowner ? 🙏

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 11, 2023
@TomohitoAndo TomohitoAndo changed the title fix(run_out): clear stop pose to prevent virtual wall from increasing fix(run_out): clear stop pose to prevent virtual wall from remaining Jul 11, 2023
Copy link
Contributor

@mkuri mkuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomohitoAndo TomohitoAndo merged commit fb4c6a6 into autowarefoundation:main Jul 13, 2023
@TomohitoAndo TomohitoAndo deleted the fix-virtual-wall-marker branch July 13, 2023 01:23
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Jul 13, 2023
…utowarefoundation#4240)

fix(run_out): clear stop pose to prevent virtual wall from increasing

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Jul 13, 2023
…663)

fix(run_out): clear stop pose to prevent virtual wall from remaining (autowarefoundation#4240)

fix(run_out): clear stop pose to prevent virtual wall from increasing

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants