Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: separate traffic_light_utils from perception_utils #4207

Merged
merged 13 commits into from
Jul 12, 2023

Conversation

miursh
Copy link
Contributor

@miursh miursh commented Jul 10, 2023

Description

I separated "traffic_light_utils" and "object_recognition_utils" from "perception_utils".
The main reason for this is to reduce dependencies for the build of "tensorrt_yolox" in the "Edge.auto" project, which relies on new "object_recognition_utils".

Tests performed

I have confirmed that whole traffic_light_recognition module and object_recognition module work correctly after this PR by logging_simulator.launch.
image
image

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Jul 10, 2023
pre-commit-ci bot and others added 2 commits July 10, 2023 01:05
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jul 10, 2023
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@miursh miursh marked this pull request as ready for review July 10, 2023 03:23
@miursh miursh requested review from manato and Mingyu1991 July 10, 2023 03:23
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miursh May I ask for some background on this PR?
I feel uncomfortable that only traffic light is separated from perception utils.

@yukkysaito
Copy link
Contributor

@miursh cc @mitsudome-r
Thanks for the updated PR description.
If you want to separate them, I'd like to go from perception_utils to object_recognition_utils.

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage: 1.88% and project coverage change: -0.83 ⚠️

Comparison is base (093f840) 15.21% compared to head (55eee99) 14.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4207      +/-   ##
==========================================
- Coverage   15.21%   14.38%   -0.83%     
==========================================
  Files        1489     1606     +117     
  Lines      102611   110553    +7942     
  Branches    31524    32027     +503     
==========================================
+ Hits        15613    15906     +293     
- Misses      70047    77315    +7268     
- Partials    16951    17332     +381     
Flag Coverage Δ *Carryforward flag
differential 10.70% <1.88%> (?)
total 14.26% <ø> (-0.96%) ⬇️ Carriedforward from 5c9ebfd

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...tils/include/object_recognition_utils/matching.hpp 60.46% <ø> (ø)
...object_recognition_utils/object_classification.hpp 60.00% <ø> (ø)
common/object_recognition_utils/src/conversion.cpp 50.00% <ø> (ø)
...ect_recognition_utils/src/predicted_path_utils.cpp 48.07% <ø> (ø)
...ect_recognition_utils/test/src/test_conversion.cpp 34.67% <ø> (ø)
...bject_recognition_utils/test/src/test_geometry.cpp 50.00% <ø> (ø)
...tion_utils/test/src/test_object_classification.cpp 16.12% <ø> (ø)
...ition_utils/test/src/test_predicted_path_utils.cpp 22.46% <ø> (ø)
...on/traffic_light_utils/src/traffic_light_utils.cpp 0.00% <ø> (ø)
...ed_object_validation/src/object_lanelet_filter.cpp 0.00% <0.00%> (ø)
... and 31 more

... and 122 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@miursh
Copy link
Contributor Author

miursh commented Jul 10, 2023

@yukkysaito
Thank you for your comment.
Do you mean separating into 'traffic_light_utils' and 'object_recognition_utils' instead of 'perception_utils'?

@yukkysaito
Copy link
Contributor

Thank you for your comment.
Do you mean separating into 'traffic_light_utils' and 'object_recognition_utils' instead of 'perception_utils'?

@miursh Yes.
If it is a common use of object_recognition and traffic_light, then perception_utils is fine.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 10, 2023
@miursh miursh marked this pull request as draft July 10, 2023 09:25
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@miursh miursh force-pushed the chore/move_traffic_light_utils branch from 17f2837 to d7a8c57 Compare July 10, 2023 09:31
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@miursh miursh marked this pull request as ready for review July 10, 2023 09:50
@miursh
Copy link
Contributor Author

miursh commented Jul 10, 2023

@yukkysaito I have renamed the most of perception_utils to object_recognition_utils.
d7a8c57

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

miursh and others added 2 commits July 10, 2023 19:49
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
…nizer.hpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Copy link
Contributor

@yukke42 yukke42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

miursh and others added 3 commits July 11, 2023 22:26
# Conflicts:
#	planning/behavior_path_planner/src/utils/safety_check.cpp
#	planning/behavior_path_planner/src/utils/utils.cpp
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@miursh miursh merged commit 97b9d56 into main Jul 12, 2023
@miursh miursh deleted the chore/move_traffic_light_utils branch July 12, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants