-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: separate traffic_light_utils from perception_utils #4207
Conversation
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miursh May I ask for some background on this PR?
I feel uncomfortable that only traffic light is separated from perception utils.
@miursh cc @mitsudome-r |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4207 +/- ##
==========================================
- Coverage 15.21% 14.38% -0.83%
==========================================
Files 1489 1606 +117
Lines 102611 110553 +7942
Branches 31524 32027 +503
==========================================
+ Hits 15613 15906 +293
- Misses 70047 77315 +7268
- Partials 16951 17332 +381
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@yukkysaito |
@miursh Yes. |
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
17f2837
to
d7a8c57
Compare
@yukkysaito I have renamed the most of perception_utils to object_recognition_utils. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
common/traffic_light_utils/include/traffic_light_utils/traffic_light_utils.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
common/perception_utils/include/perception_utils/prime_synchronizer.hpp
Outdated
Show resolved
Hide resolved
…nizer.hpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# Conflicts: # planning/behavior_path_planner/src/utils/safety_check.cpp # planning/behavior_path_planner/src/utils/utils.cpp
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Description
I separated "traffic_light_utils" and "object_recognition_utils" from "perception_utils".
The main reason for this is to reduce dependencies for the build of "tensorrt_yolox" in the "Edge.auto" project, which relies on new "object_recognition_utils".
Tests performed
I have confirmed that whole traffic_light_recognition module and object_recognition module work correctly after this PR by logging_simulator.launch.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.