Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avoidance): consider acceleration during avoidance maneuver #4186

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jul 6, 2023

Description

🤖 Generated by Copilot at aa0a6c9

This pull request refactors and improves the avoidance logic of the behavior path planner. It simplifies the configuration file by removing two parameters and adding one for limiting lateral acceleration. It also removes unused code and updates the documentation accordingly.

Please approve ⬇️ before this PR.
autowarefoundation/autoware_launch#436

Tests performed

Effects on system behavior

Make it possible to accelerate during avoidance maneuver.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 9.09% and no project coverage change.

Comparison is base (8c982e5) 14.16% compared to head (24f6bbb) 14.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4186   +/-   ##
=======================================
  Coverage   14.16%   14.16%           
=======================================
  Files        1586     1586           
  Lines      109537   109499   -38     
  Branches    31451    31429   -22     
=======================================
- Hits        15518    15515    -3     
+ Misses      77130    77102   -28     
+ Partials    16889    16882    -7     
Flag Coverage Δ *Carryforward flag
differential 13.51% <9.09%> (?)
total 14.17% <ø> (+<0.01%) ⬆️ Carriedforward from 8c982e5

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <ø> (ø)
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...ath_planner/src/scene_module/avoidance/manager.cpp 7.42% <0.00%> (ø)
...lanner/include/obstacle_avoidance_planner/node.hpp 40.00% <ø> (ø)
...ng/obstacle_avoidance_planner/src/debug_marker.cpp 45.56% <ø> (ø)
planning/obstacle_avoidance_planner/src/node.cpp 40.41% <ø> (+0.17%) ⬆️
...cle_avoidance_planner/src/utils/geometry_utils.cpp 50.00% <ø> (ø)
...e_avoidance_planner/src/utils/trajectory_utils.cpp 44.82% <ø> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 11.77% <10.52%> (+0.26%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota force-pushed the feat/avoidance-with-acceleration branch from aa0a6c9 to 24f6bbb Compare July 10, 2023 03:01
@satoshi-ota satoshi-ota marked this pull request as ready for review July 10, 2023 03:04
@satoshi-ota satoshi-ota changed the title feat(avoidance): take acceleration during avoidance maneuver into consideration feat(avoidance): consider acceleration during avoidance maneuver Jul 10, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…ce maneuver

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the feat/avoidance-with-acceleration branch from 24f6bbb to cb72159 Compare July 10, 2023 06:25
@kyoichi-sugahara kyoichi-sugahara self-assigned this Jul 12, 2023
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit b12feef into autowarefoundation:main Jul 12, 2023
@satoshi-ota satoshi-ota deleted the feat/avoidance-with-acceleration branch July 12, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants