fix(avoidance): don't output new candidate path if there is huge offset between the ego and previous output path #4150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
satoshi-ota
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
4 tasks
rej55
approved these changes
Jul 3, 2023
satoshi-ota
force-pushed
the
fix/avoidance-keep-path
branch
from
9b3bcd6 to
4de7085
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4150 +/- ##
=======================================
Coverage 14.29% 14.29%
=======================================
Files 1574 1574
Lines 108448 108455 +7
Branches 31374 31380 +6
=======================================
+ Hits 15503 15504 +1
- Misses 76093 76095 +2
- Partials 16852 16856 +4
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
satoshi-ota
force-pushed
the
fix/avoidance-keep-path
branch
2 times, most recently
from
5e00e8d to
f0f365c
Compare
github-actions
bot
added
the
type:documentation
satoshi-ota
force-pushed
the
fix/avoidance-keep-path
branch
2 times, most recently
from
0641b71 to
9d9e456
Compare
…et between the ego and previous output path Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
force-pushed
the
fix/avoidance-keep-path
branch
from
9d9e456 to
f87a1da
Compare
satoshi-ota
added a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
Jul 5, 2023
…et between the ego and previous output path (autowarefoundation#4150) * fix(avoidance): don't output new candidate path if there is huge offset between the ego and previous output path Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * docs(avoidance): add parameter description Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
4 tasks
tkimura4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 5, 2023
…et between the ego and previous output path (autowarefoundation#4150) (#645) * fix(avoidance): don't output new candidate path if there is huge offset between the ego and previous output path * docs(avoidance): add parameter description --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖 Generated by Copilot at 9b3bcd6
Added a new parameter
safety_check_ego_offsetto theAvoidanceParametersstruct and used it to limit the output of new candidate paths for obstacle avoidance in theAvoidanceModuleclass. This is a safety measure to prevent sudden or unrealistic path changes in some scenarios.Please approve ⬇️ before this PR.
autowarefoundation/autoware_launch#431
Tests performed
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.