-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tensorrt_yolox): yolox extra bbox with zero value #4089
fix(tensorrt_yolox): yolox extra bbox with zero value #4089
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4089 +/- ##
==========================================
- Coverage 15.29% 15.21% -0.09%
==========================================
Files 1461 1466 +5
Lines 101218 101763 +545
Branches 31216 31168 -48
==========================================
- Hits 15484 15479 -5
- Misses 68899 69464 +565
+ Partials 16835 16820 -15
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>
a6a5831
to
c5ff69e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
In the current code, the yolox node with yolox-tiny model outputs extra bounding boxes with zero values.
For example, if the model detects 3 objects, the node outputs will be 6 bounding boxes and half of them contain
(x, y, w, h, score) = (0, 0, 0, 0, 0).
This PR fixes the above-unintended behavior.
Tests performed
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.