Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tensorrt_yolox): yolox extra bbox with zero value #4089

Merged

Conversation

manato
Copy link
Contributor

@manato manato commented Jun 27, 2023

Description

In the current code, the yolox node with yolox-tiny model outputs extra bounding boxes with zero values.
For example, if the model detects 3 objects, the node outputs will be 6 bounding boxes and half of them contain
(x, y, w, h, score) = (0, 0, 0, 0, 0).

This PR fixes the above-unintended behavior.

Tests performed

ros2 launch tensorrt_yolox yolox_tiny.launch.xml

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@manato manato requested a review from miursh June 27, 2023 02:24
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.09 ⚠️

Comparison is base (084c7e2) 15.29% compared to head (9159617) 15.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4089      +/-   ##
==========================================
- Coverage   15.29%   15.21%   -0.09%     
==========================================
  Files        1461     1466       +5     
  Lines      101218   101763     +545     
  Branches    31216    31168      -48     
==========================================
- Hits        15484    15479       -5     
- Misses      68899    69464     +565     
+ Partials    16835    16820      -15     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.30% <ø> (+<0.01%) ⬆️ Carriedforward from c5ff69e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
perception/tensorrt_yolox/src/tensorrt_yolox.cpp 0.00% <0.00%> (ø)
...avior_path_planner/marker_util/debug_utilities.hpp 0.00% <ø> (ø)
...th_planner/scene_module/lane_change/base_class.hpp 17.07% <ø> (+0.79%) ⬆️
...nner/utils/lane_change/lane_change_module_data.hpp 50.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 18.64% <ø> (+0.27%) ⬆️
...path_planner/src/marker_util/lane_change/debug.cpp 0.00% <ø> (ø)
...th_planner/src/scene_module/lane_change/normal.cpp 4.87% <ø> (+0.04%) ⬆️
...avior_path_planner/src/utils/lane_change/utils.cpp 0.40% <ø> (+<0.01%) ⬆️
...g/behavior_path_planner/src/utils/safety_check.cpp 31.57% <ø> (+3.45%) ⬆️
...g/behavior_path_planner/test/test_safety_check.cpp 43.24% <ø> (-1.63%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@manato manato changed the title fix: yolox extra bbox with zero value fix(tensorrt_yolox): yolox extra bbox with zero value Jun 27, 2023
@github-actions github-actions bot removed the type:documentation Creating or refining documentation. (auto-assigned) label Jun 27, 2023
Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>
@manato manato force-pushed the fix/yolox_extra_bbox_with_zero_value branch from a6a5831 to c5ff69e Compare June 27, 2023 04:43
@manato manato marked this pull request as ready for review June 27, 2023 05:19
@manato manato requested review from wep21, dan-dnn and a team as code owners June 27, 2023 05:19
@manato manato requested a review from yukkysaito June 27, 2023 05:19
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manato manato enabled auto-merge (squash) June 27, 2023 09:09
@miursh
Copy link
Contributor

miursh commented Jun 27, 2023

Looks work fine
image

Copy link
Contributor

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manato manato merged commit 3d293de into autowarefoundation:main Jun 28, 2023
@manato manato deleted the fix/yolox_extra_bbox_with_zero_value branch June 28, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants