feat(traffic_light_occlusion_predictor): add traffic_light_occlusion_predictor #4050

Mingyu1991 · 2023-06-22T16:06:03Z

Description

The new package point cloud-based traffic_light_occlusion_predictor is submitted in this PR.
updates within perception_utils and tier4_autoware_utils.

Tests performed

Nothing.

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>

knzo25 · 2023-06-23T01:18:07Z

@Mingyu1991
Just a comment, but you may find this method interesting
https://pointclouds.org/documentation/classpcl_1_1_frustum_culling.html

miursh · 2023-06-28T12:39:06Z

@Mingyu1991
Could you please provide the description using the PR template, just like other PRs have done?

...tion/traffic_light_occlusion_predictor/include/traffic_light_occlusion_predictor/nodelet.hpp

Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>

common/perception_utils/include/perception_utils/prime_synchronizer.hpp

perception/traffic_light_occlusion_predictor/README.md

perception/traffic_light_occlusion_predictor/src/occlusion_predictor.cpp

perception/traffic_light_occlusion_predictor/README.md

...eption/traffic_light_occlusion_predictor/config/traffic_light_occlusion_predictor.param.yaml

perception/traffic_light_occlusion_predictor/src/occlusion_predictor.cpp

Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>

miursh

LGTM

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

codecov · 2023-07-06T19:36:40Z

Codecov Report

Patch coverage has no change and project coverage change: -0.07 ⚠️

Comparison is base (f5b4053) 14.31% compared to head (eb5bc50) 14.24%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4050      +/-   ##
==========================================
- Coverage   14.31%   14.24%   -0.07%     
==========================================
  Files        1572     1578       +6     
  Lines      108312   112326    +4014     
  Branches    31244    33827    +2583     
==========================================
+ Hits        15501    15998     +497     
- Misses      75956    78837    +2881     
- Partials    16855    17491     +636

Flag	Coverage Δ		*Carryforward flag
differential	`18.00% <0.00%> (?)`
total	`14.31% <ø> (ø)`		Carriedforward from f5b4053

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...ommon/perception_utils/src/traffic_light_utils.cpp	`0.00% <0.00%> (ø)`
..._light_occlusion_predictor/occlusion_predictor.hpp	`0.00% <0.00%> (ø)`
.../traffic_light_occlusion_predictor/src/nodelet.cpp	`0.00% <0.00%> (ø)`
...ht_occlusion_predictor/src/occlusion_predictor.cpp	`0.00% <0.00%> (ø)`

... and 49 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

…predictor (autowarefoundation#4050) * add traffic_light_occlusion_predictor Signed-off-by: Mingyu Li <mingyu.li@tier4.jp> * update README Signed-off-by: Mingyu Li <mingyu.li@tier4.jp> * update occlusion package I/F Signed-off-by: Mingyu Li <mingyu.li@tier4.jp> * revert wrong update of README.md Signed-off-by: Mingyu Li <mingyu.li@tier4.jp> * update perception_utils Signed-off-by: Mingyu Li <mingyu.li@tier4.jp> * add _deg to variables and update README Signed-off-by: Mingyu Li <mingyu.li@tier4.jp> * fix Cmakelists Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> --------- Signed-off-by: Mingyu Li <mingyu.li@tier4.jp> Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> Co-authored-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* feat(traffic_light_occlusion_predictor): add traffic_light_occlusion_predictor (autowarefoundation#4050) * add traffic_light_occlusion_predictor Signed-off-by: Mingyu Li <mingyu.li@tier4.jp> * update README Signed-off-by: Mingyu Li <mingyu.li@tier4.jp> * update occlusion package I/F Signed-off-by: Mingyu Li <mingyu.li@tier4.jp> * revert wrong update of README.md Signed-off-by: Mingyu Li <mingyu.li@tier4.jp> * update perception_utils Signed-off-by: Mingyu Li <mingyu.li@tier4.jp> * add _deg to variables and update README Signed-off-by: Mingyu Li <mingyu.li@tier4.jp> * fix Cmakelists Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> --------- Signed-off-by: Mingyu Li <mingyu.li@tier4.jp> Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> Co-authored-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * feat(traffic_light_classifier): update traffic_light_classifier and traffic_light_fine_detector (autowarefoundation#4125) * first commit Signed-off-by: Mingyu Li <mingyu.li@tier4.jp> * fix typo Signed-off-by: Mingyu Li <mingyu.li@tier4.jp> * Revert unnecessary changes Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * change to fit previous revert Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * fix: correct style Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp> * fix: use proper initializer Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp> * fix build_config constructor Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * pre-commit Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> --------- Signed-off-by: Mingyu Li <mingyu.li@tier4.jp> Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp> Co-authored-by: Shunsuke Miura <shunsuke.miura@tier4.jp> Co-authored-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp> Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com> * feat(traffic_light_selector): remove traffic light selector (autowarefoundation#4130) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(traffic_light): improved traffic_light_map_based_detector and new traffic_light_fine_detector package (autowarefoundation#4084) * update traffic_light_map_based_detector traffic_light_classifier traffic_light_fine_detector traffic_light_multi_camera_fusion Signed-off-by: Mingyu Li <mingyu.li@tier4.jp> * replace autoware_auto_perception_msgs with tier4_perception_msgs Signed-off-by: Mingyu Li <mingyu.li@tier4.jp> --------- Signed-off-by: Mingyu Li <mingyu.li@tier4.jp> * feat: rename traffic signal element (autowarefoundation#4129) * feat(traffic_light_arbiter): rename traffic signal element Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(traffic_light_selector): remove traffic light selector Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix(traffic_light_arbiter): fix node name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * update topic name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * update message type Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * update message type Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> --------- Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> --------- Signed-off-by: Mingyu Li <mingyu.li@tier4.jp> Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp> Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Mingyu1991 <115005477+Mingyu1991@users.noreply.github.com> Co-authored-by: Shunsuke Miura <shunsuke.miura@tier4.jp> Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com> Co-authored-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp> Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com> Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>

add traffic_light_occlusion_predictor

2e1d027

Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>

Mingyu1991 requested review from kenji-miyake, TakaHoribe, takayuki5168, purewater0901, a team, scepter914, miursh and yukke42 as code owners June 22, 2023 16:06

update README

812ec03

Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>

miursh mentioned this pull request Jun 27, 2023

feat(tier4_perception_msgs): add traffic light msgs tier4/tier4_autoware_msgs#93

Merged

miursh reviewed Jun 28, 2023

View reviewed changes

...tion/traffic_light_occlusion_predictor/include/traffic_light_occlusion_predictor/nodelet.hpp Outdated Show resolved Hide resolved

Mingyu1991 and others added 4 commits June 30, 2023 10:54

update occlusion package I/F

277411d

Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>

revert wrong update of README.md

648d5e8

Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>

Merge branch 'main' into feat/traffic_light_occlusion_predictor

4d06b83

update perception_utils

684dc8a

Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>

miursh reviewed Jul 3, 2023

View reviewed changes

add _deg to variables and update README

692e1e5

Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>

Mingyu1991 mentioned this pull request Jul 5, 2023

feat(tier4_perception_launch): update traffic light launch #4176

Merged

4 tasks

miursh approved these changes Jul 6, 2023

View reviewed changes

fix Cmakelists

eb5bc50

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

miursh merged commit ca37348 into autowarefoundation:main Jul 6, 2023

Mingyu1991 deleted the feat/traffic_light_occlusion_predictor branch July 7, 2023 01:35

tier4-autoware-public-bot bot mentioned this pull request Jul 7, 2023

chore: sync upstream tier4/autoware.universe#648

Merged

miursh mentioned this pull request Jul 8, 2023

Change traffic signal interface to support V2X/V2I #2567

Closed

8 tasks

miursh linked an issue Jul 8, 2023 that may be closed by this pull request

Change traffic signal interface to support V2X/V2I #2567

Closed

8 tasks

miursh removed a link to an issue Jul 8, 2023

Change traffic signal interface to support V2X/V2I #2567

Closed

8 tasks

saka1-s mentioned this pull request Jul 21, 2023

chore: update traffic light message of perception modules tier4/autoware.universe#677

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(traffic_light_occlusion_predictor): add traffic_light_occlusion_predictor #4050

feat(traffic_light_occlusion_predictor): add traffic_light_occlusion_predictor #4050

Mingyu1991 commented Jun 22, 2023 •

edited by miursh

Loading

knzo25 commented Jun 23, 2023

miursh commented Jun 28, 2023

miursh left a comment

codecov bot commented Jul 6, 2023

feat(traffic_light_occlusion_predictor): add traffic_light_occlusion_predictor #4050

feat(traffic_light_occlusion_predictor): add traffic_light_occlusion_predictor #4050

Conversation

Mingyu1991 commented Jun 22, 2023 • edited by miursh Loading

Description

Tests performed

Effects on system behavior

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

knzo25 commented Jun 23, 2023

miursh commented Jun 28, 2023

miursh left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 6, 2023

Codecov Report

Mingyu1991 commented Jun 22, 2023 •

edited by miursh

Loading