fix(avoidance): don't reset registered shift lines if the base offset is not zero #3971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
…an zero Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
force-pushed
the
fix/avoid-new-shift
branch
from
716f8dd to
488720e
Compare
…ft lines Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
force-pushed
the
fix/avoid-new-shift
branch
from
488720e to
1de6825
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3971 +/- ##
=======================================
Coverage 14.41% 14.41%
=======================================
Files 1456 1456
Lines 102660 102658 -2
Branches 29728 29731 +3
=======================================
Hits 14795 14795
+ Misses 71705 71703 -2
Partials 16160 16160
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
satoshi-ota
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901,
zulfaqar-azmi-t4 and
a team
as code owners
shmpwk
reviewed
Jun 14, 2023
...avior_path_planner/include/behavior_path_planner/scene_module/avoidance/avoidance_module.hpp
Show resolved
Hide resolved
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 14, 2023
… is not zero (autowarefoundation#3971) * fix(avoidance): break if the shift line start longitudinal is less than zero Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): check base offset before resetting of registered shift lines Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
4 tasks
tkimura4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 14, 2023
… is not zero (autowarefoundation#3971) (#579) * fix(avoidance): break if the shift line start longitudinal is less than zero * feat(avoidance): check base offset before resetting of registered shift lines --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
1222-takeshi
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 20, 2023
… is not zero (autowarefoundation#3971) * fix(avoidance): break if the shift line start longitudinal is less than zero Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): check base offset before resetting of registered shift lines Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
added a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
Jun 20, 2023
… is not zero (autowarefoundation#3971) * fix(avoidance): break if the shift line start longitudinal is less than zero Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): check base offset before resetting of registered shift lines Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't reset registered shift linew if the base offset is NOT zero.
Otherwise, the current path will be updated suddenly like this.
Screencast.from.2023.06.13.17.14.43.webm
[TIER IV INTERNAL LINK]
Tests performed
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.