-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(avoidance): use same root adjacent lane boundary for avoidable margin calculation #3860
feat(avoidance): use same root adjacent lane boundary for avoidable margin calculation #3860
Conversation
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
590bc7c
to
a03a106
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3860 +/- ##
==========================================
- Coverage 14.08% 14.08% -0.01%
==========================================
Files 1441 1441
Lines 101722 101748 +26
Branches 27086 27106 +20
==========================================
Hits 14330 14330
- Misses 71701 71723 +22
- Partials 15691 15695 +4
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…argin calculation (autowarefoundation#3860) * feat(route_handler): add option to get same root right/left lane Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): check road bound with same root adjacent lane option Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…argin calculation (autowarefoundation#3860) * feat(route_handler): add option to get same root right/left lane Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): check road bound with same root adjacent lane option Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…argin calculation (autowarefoundation#3860) * feat(route_handler): add option to get same root right/left lane Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): check road bound with same root adjacent lane option Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Description
Add option to get same root (=
previous lanelet
) right/left lanelet fromcurrent lanelet
.Tests performed
Before this PR. It is NOT possible to get right lanelet from turn left lanelet. As a result, the ego can't avoid object because of the avoidable bounds.
Avoidable area bounds (pink bold line) is expanded correctly.
Effects on system behavior
Improve avoidance maneuver.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.