Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avoidance): use same root adjacent lane boundary for avoidable margin calculation #3860

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented May 30, 2023

Description

Add option to get same root (=previous lanelet) right/left lanelet from current lanelet.

image

Tests performed

Before this PR. It is NOT possible to get right lanelet from turn left lanelet. As a result, the ego can't avoid object because of the avoidable bounds.

image

Avoidable area bounds (pink bold line) is expanded correctly.

image

Effects on system behavior

Improve avoidance maneuver.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 30, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the feat/use-same-root-adjacent-lane branch from 590bc7c to a03a106 Compare May 30, 2023 01:34
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 14.89% and project coverage change: -0.01 ⚠️

Comparison is base (4856894) 14.08% compared to head (a03a106) 14.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3860      +/-   ##
==========================================
- Coverage   14.08%   14.08%   -0.01%     
==========================================
  Files        1441     1441              
  Lines      101722   101748      +26     
  Branches    27086    27106      +20     
==========================================
  Hits        14330    14330              
- Misses      71701    71723      +22     
- Partials    15691    15695       +4     
Flag Coverage Δ *Carryforward flag
differential 11.13% <14.89%> (?)
total 14.08% <ø> (-0.01%) ⬇️ Carriedforward from 4856894

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ehavior_path_planner/src/utils/avoidance/utils.cpp 3.48% <0.00%> (ø)
planning/route_handler/src/route_handler.cpp 24.47% <15.90%> (-0.77%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 3053f77 into autowarefoundation:main Jun 1, 2023
@satoshi-ota satoshi-ota deleted the feat/use-same-root-adjacent-lane branch June 1, 2023 01:51
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jun 1, 2023
…argin calculation (autowarefoundation#3860)

* feat(route_handler): add option to get same root right/left lane

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): check road bound with same root adjacent lane option

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Jun 7, 2023
…argin calculation (autowarefoundation#3860)

* feat(route_handler): add option to get same root right/left lane

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): check road bound with same root adjacent lane option

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Jun 20, 2023
…argin calculation (autowarefoundation#3860)

* feat(route_handler): add option to get same root right/left lane

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): check road bound with same root adjacent lane option

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants