-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(autonomous_emergency_braking): fix imu tranform to base_link #3812
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3812 +/- ##
==========================================
- Coverage 14.11% 14.11% -0.01%
==========================================
Files 1438 1438
Lines 101485 101424 -61
Branches 27045 27019 -26
==========================================
- Hits 14329 14319 -10
+ Misses 71472 71426 -46
+ Partials 15684 15679 -5
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…owarefoundation#3812) (#522) (cherry picked from commit 156d52f)
…owarefoundation#3812) (backport #522) (#524) fix(autonomous_emergency_braking): fix imu tranform to base_link (autowarefoundation#3812) (#522) (cherry picked from commit 156d52f) Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Description
This node uses original IMU value, so trajectory made by odometry is opposite direction when IMU is located upside down.
I'll fix it to use tranform.
In addition, I do transform only angular velocity because other informartion is not used.
Related links
https://tier4.atlassian.net/browse/AEAP-557
Tests performed
I confirmed frajectory is right direction by below rosbag.
https://drive.google.com/file/d/1LdELkVLbqb8twDXPr-cU538EZVscSX5j/view?usp=sharing
This rosbag has necesarry information only.
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.