Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autonomous_emergency_braking): fix imu tranform to base_link #3812

Merged
merged 3 commits into from
May 25, 2023

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented May 25, 2023

Description

This node uses original IMU value, so trajectory made by odometry is opposite direction when IMU is located upside down.
I'll fix it to use tranform.
In addition, I do transform only angular velocity because other informartion is not used.

Related links

https://tier4.atlassian.net/browse/AEAP-557

Tests performed

I confirmed frajectory is right direction by below rosbag.
https://drive.google.com/file/d/1LdELkVLbqb8twDXPr-cU538EZVscSX5j/view?usp=sharing
This rosbag has necesarry information only.

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta requested review from TakaHoribe, purewater0901 and a team as code owners May 25, 2023 01:57
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (c1de8fd) 14.11% compared to head (76e13ff) 14.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3812      +/-   ##
==========================================
- Coverage   14.11%   14.11%   -0.01%     
==========================================
  Files        1438     1438              
  Lines      101485   101424      -61     
  Branches    27045    27019      -26     
==========================================
- Hits        14329    14319      -10     
+ Misses      71472    71426      -46     
+ Partials    15684    15679       -5     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.11% <ø> (+<0.01%) ⬆️ Carriedforward from 051cab6

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...manager_rviz_plugin/src/bag_time_manager_panel.cpp 0.00% <ø> (ø)
.../rtc_manager_rviz_plugin/src/rtc_manager_panel.cpp 0.00% <ø> (ø)
...tic_goal_rviz_plugin/src/automatic_goal_sender.cpp 0.00% <ø> (ø)
...ontrol_rviz_plugin/src/tools/manual_controller.cpp 0.00% <ø> (ø)
...er4_state_rviz_plugin/src/autoware_state_panel.cpp 0.00% <ø> (ø)
...king/include/autonomous_emergency_braking/node.hpp 0.00% <ø> (ø)
control/autonomous_emergency_braking/src/node.cpp 0.00% <0.00%> (ø)
...troller/src/joy_controller/joy_controller_node.cpp 0.00% <ø> (ø)
...ization/ndt_scan_matcher/src/map_update_module.cpp 0.00% <ø> (ø)
...de_manager/src/rtc_auto_mode_manager_interface.cpp 0.00% <ø> (ø)
... and 1 more

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-ohta h-ohta enabled auto-merge (squash) May 25, 2023 06:34
@h-ohta h-ohta merged commit 938503d into autowarefoundation:main May 25, 2023
@h-ohta h-ohta deleted the fix/imu_tf_base_link branch May 25, 2023 08:18
h-ohta added a commit to tier4/autoware.universe that referenced this pull request May 25, 2023
h-ohta added a commit to tier4/autoware.universe that referenced this pull request May 25, 2023
mergify bot pushed a commit to tier4/autoware.universe that referenced this pull request May 25, 2023
h-ohta added a commit to tier4/autoware.universe that referenced this pull request May 25, 2023
…owarefoundation#3812) (backport #522) (#524)

fix(autonomous_emergency_braking): fix imu tranform to base_link (autowarefoundation#3812) (#522)

(cherry picked from commit 156d52f)

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants