Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): add drivable area information #3660

Merged
merged 4 commits into from
May 10, 2023

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented May 10, 2023

Description

Before this change, in createGoalAroundPath(), drivable area information is not included.
In this change, I add drivable area information to createGoalAroundPath().

Related links

Tests performed

Tested in planning simulator.

Notes for reviewers

Interface changes

Nothing.

Effects on system behavior

Behavior planning module will not die.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 10, 2023
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
@rej55 rej55 force-pushed the fix/create_goal_around_path branch from 3554b06 to 75b5744 Compare May 10, 2023 06:44
rej55 added 3 commits May 10, 2023 15:57
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
and confirmed problem rerated with generateCombinedDrivableArea() is solved in new architecture

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 23.07% and project coverage change: +0.01 🎉

Comparison is base (3fffbe7) 13.84% compared to head (6c7e1c9) 13.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3660      +/-   ##
==========================================
+ Coverage   13.84%   13.86%   +0.01%     
==========================================
  Files        1396     1396              
  Lines       98375    98513     +138     
  Branches    29309    29399      +90     
==========================================
+ Hits        13619    13654      +35     
- Misses      69976    70037      +61     
- Partials    14780    14822      +42     
Flag Coverage Δ *Carryforward flag
differential 13.20% <23.07%> (?)
total 13.84% <ø> (-0.01%) ⬇️ Carriedforward from 3fffbe7

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nner/include/behavior_path_planner/utils/utils.hpp 45.45% <ø> (ø)
...ehavior_path_planner/src/behavior_tree_manager.cpp 63.51% <0.00%> (-0.13%) ⬇️
planning/behavior_path_planner/src/utils/utils.cpp 17.03% <25.00%> (+1.10%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tkimura4 tkimura4 merged commit c41ba06 into autowarefoundation:main May 10, 2023
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request May 11, 2023
…undation#3660)

* fix(behavior_path_planner): add drivable area information

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* fix(behavior_path_planner): fix typo

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* fix(behavior_path_planner): fix cmake

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* fix(behavior_path_planner): cosmetic change

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

---------

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request May 11, 2023
…undation#3660) (#421)

* fix(behavior_path_planner): add drivable area information



* fix(behavior_path_planner): fix typo



* fix(behavior_path_planner): fix cmake



* fix(behavior_path_planner): cosmetic change



---------

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
@rej55 rej55 deleted the fix/create_goal_around_path branch December 8, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants