-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_path_planner): add drivable area information #3660
fix(behavior_path_planner): add drivable area information #3660
Conversation
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
3554b06
to
75b5744
Compare
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
and confirmed problem rerated with generateCombinedDrivableArea()
is solved in new architecture
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3660 +/- ##
==========================================
+ Coverage 13.84% 13.86% +0.01%
==========================================
Files 1396 1396
Lines 98375 98513 +138
Branches 29309 29399 +90
==========================================
+ Hits 13619 13654 +35
- Misses 69976 70037 +61
- Partials 14780 14822 +42
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…undation#3660) * fix(behavior_path_planner): add drivable area information Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * fix(behavior_path_planner): fix typo Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * fix(behavior_path_planner): fix cmake Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * fix(behavior_path_planner): cosmetic change Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> --------- Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
…undation#3660) (#421) * fix(behavior_path_planner): add drivable area information * fix(behavior_path_planner): fix typo * fix(behavior_path_planner): fix cmake * fix(behavior_path_planner): cosmetic change --------- Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Description
Before this change, in
createGoalAroundPath()
, drivable area information is not included.In this change, I add drivable area information to
createGoalAroundPath()
.Related links
Tests performed
Tested in planning simulator.
Notes for reviewers
Interface changes
Nothing.
Effects on system behavior
Behavior planning module will not die.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.