-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: proper eigen deps and include #3615
Conversation
Signed-off-by: Vincent Richard <richard-v@macnica.co.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3615 +/- ##
=======================================
Coverage 13.72% 13.73%
=======================================
Files 1397 1397
Lines 98263 98263
Branches 29238 29238
=======================================
+ Hits 13490 13493 +3
+ Misses 70233 70232 -1
+ Partials 14540 14538 -2
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
* build: proper eigen deps and include Signed-off-by: Vincent Richard <richard-v@macnica.co.jp> * style(pre-commit): autofix --------- Signed-off-by: Vincent Richard <richard-v@macnica.co.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Description
As mentioned here, including eigen headers with
#include <eigen3/Eigen/*>
is not "correct". For example, if someone downloads andinstalls eigen library from source manually,
<depend>eigen</depend>
andfind_package(Eigen3)
will work fine but the header may not be found, or the system eigen library header will be used instead if installed on the system (mixing Eigen version within the same compilation unit is most likely UB).This PR replaces all
#include <eigen3/Eigen/XXX>
and#include "eigen3/Eigen/XXX"
by the appropriate equivalent. Eigen dependency is added when necessary.Tests performed
If it compiles, it should be Ok
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.