Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): renew lane change collision check functions #3609

Merged
merged 6 commits into from
May 8, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented May 2, 2023

Description

Currently, the lane change module does not evaluate the collisions with other road participants appropriately, and it sometimes returns wrong judges. In this PR, I fixed the problem by changing the collision check algorithm. The detail of the new collision check is that

  1. Judge rear and front vehicle from the lane change path
  2. transform coordinates based on the rear vehicle
  3. calculate lateral distance and see the distance is safe or not
  4. calculate longitudinal distance and see the distance is safe or not

Related links

Tests performed

Scenario Test 1323/1350
TIER4 Internal Link

Notes for reviewers

Interface changes

There are no interface changes.

Effects on system behavior

The result of the collision check of the lane change might be varied depending on the situation.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 2, 2023
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 15.00% and project coverage change: -0.11 ⚠️

Comparison is base (6682ce0) 13.81% compared to head (bc10009) 13.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3609      +/-   ##
==========================================
- Coverage   13.81%   13.71%   -0.11%     
==========================================
  Files        1396     1399       +3     
  Lines       97942    98309     +367     
  Branches    29091    29261     +170     
==========================================
- Hits        13535    13487      -48     
- Misses      69785    70257     +472     
+ Partials    14622    14565      -57     
Flag Coverage Δ *Carryforward flag
differential 12.85% <15.00%> (?)
total 13.73% <ø> (-0.09%) ⬇️ Carriedforward from 9524ce7

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...clude/behavior_path_planner/utils/safety_check.hpp 0.00% <ø> (ø)
...avior_path_planner/src/utils/lane_change/utils.cpp 0.81% <0.00%> (ø)
...g/behavior_path_planner/src/utils/safety_check.cpp 0.00% <0.00%> (-5.36%) ⬇️
...st/test_obstacle_cruise_planner_node_interface.cpp 9.09% <ø> (-4.25%) ⬇️
...tor/test/test_scenario_selector_node_interface.cpp 30.76% <ø> (ø)
.../behavior_path_planner/src/turn_signal_decider.cpp 50.73% <92.30%> (+1.76%) ⬆️
...avior_path_planner/test/test_lane_change_utils.cpp 77.77% <100.00%> (ø)

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@purewater0901 purewater0901 merged commit 52127f0 into main May 8, 2023
@purewater0901 purewater0901 deleted the feat/use-new-collision-check-algorithm branch May 8, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants