-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): renew lane change collision check functions #3609
Conversation
Signed-off-by: yutaka <purewater0901@gmail.com>
…n-check-algorithm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…utowarefoundation/autoware.universe into feat/use-new-collision-check-algorithm
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3609 +/- ##
==========================================
- Coverage 13.81% 13.71% -0.11%
==========================================
Files 1396 1399 +3
Lines 97942 98309 +367
Branches 29091 29261 +170
==========================================
- Hits 13535 13487 -48
- Misses 69785 70257 +472
+ Partials 14622 14565 -57
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Description
Currently, the lane change module does not evaluate the collisions with other road participants appropriately, and it sometimes returns wrong judges. In this PR, I fixed the problem by changing the collision check algorithm. The detail of the new collision check is that
Related links
Tests performed
Scenario Test 1323/1350
TIER4 Internal Link
Notes for reviewers
Interface changes
There are no interface changes.
Effects on system behavior
The result of the collision check of the lane change might be varied depending on the situation.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.