Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): expand hatched road markings #3604

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented May 1, 2023

Description

Currently, we cannot utilize the area of hatched road markings for obstacle avoidance.

In the following discussion, the area of hatched road markings is defined, and with this PR we can expand the drivable area with the area of hatched road markings.
https://github.com/orgs/autowarefoundation/discussions/3414

launcher PR: autowarefoundation/autoware_launch#337

code change

  • add enable_expanding_hatched_road_markings in DrivableAreaInfo
    • In avoidance module, this variable may be enabled depending on use_hatched_road_markings ros parameters.
    • This ros parameter is set to false by default since in Turkey it is prohibited to drive in the area of hatched road markings.
  • implement the feature of expanding the drivable area with hatched road markings polygons in generateDrivableArea function.
    • For old architecture, the argument of enable_expanding_hatched_road_markings is set to false.

result

exampl1
image
In the above figure, the yellow polygon is the hatched road markings.
image
image

example2
image
In the above figure, the yellow polygon is the hatched road markings.
image
image

Tests performed

planning simulator

Effects on system behavior

Can use hatched road markings for obstacle avoidance

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 1, 2023
@takayuki5168 takayuki5168 changed the title Feat/expand hatched road markings feat(behavior_path_planner): expand hatched road markings May 1, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review May 1, 2023 15:28
@yukkysaito
Copy link
Contributor

Can you please describe it in the autoware ll2 extension documentation?
https://github.com/autowarefoundation/autoware_common/blob/main/tmp/lanelet2_extension/docs/lanelet2_format_extension.md

@takayuki5168 takayuki5168 force-pushed the feat/expand-hatched-road-markings branch 2 times, most recently from c366613 to a71df29 Compare May 8, 2023 08:53
Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove avoidance_by_lc directory?

It is removed by #3632.

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 25.24% and project coverage change: -0.02 ⚠️

Comparison is base (52127f0) 14.69% compared to head (b23f68e) 14.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3604      +/-   ##
==========================================
- Coverage   14.69%   14.68%   -0.02%     
==========================================
  Files        1297     1297              
  Lines       92187    92498     +311     
  Branches    29147    29355     +208     
==========================================
+ Hits        13550    13583      +33     
- Misses      63980    64228     +248     
- Partials    14657    14687      +30     
Flag Coverage Δ *Carryforward flag
differential 12.93% <25.24%> (?)
total 14.69% <ø> (+<0.01%) ⬆️ Carriedforward from 52127f0

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ner/include/behavior_path_planner/data_manager.hpp 37.50% <ø> (ø)
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...nner/include/behavior_path_planner/utils/utils.hpp 45.45% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 19.60% <0.00%> (-0.03%) ⬇️
...er/src/scene_module/avoidance/avoidance_module.cpp 3.67% <0.00%> (-0.01%) ⬇️
.../scene_module/goal_planner/goal_planner_module.cpp 5.99% <0.00%> (ø)
...th_planner/src/scene_module/lane_change/normal.cpp 6.74% <0.00%> (ø)
...nner/src/scene_module/pull_out/pull_out_module.cpp 3.72% <0.00%> (ø)
.../src/scene_module/side_shift/side_shift_module.cpp 10.83% <0.00%> (-0.06%) ⬇️
...path_planner/src/utils/pull_out/shift_pull_out.cpp 3.60% <0.00%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 28.15% and no project coverage change.

Comparison is base (ce1255a) 13.82% compared to head (086f31f) 13.82%.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3604    +/-   ##
========================================
  Coverage   13.82%   13.82%            
========================================
  Files        1395     1395            
  Lines       98083    98367   +284     
  Branches    29155    29339   +184     
========================================
+ Hits        13556    13598    +42     
- Misses      69872    70073   +201     
- Partials    14655    14696    +41     
Flag Coverage Δ *Carryforward flag
differential 12.91% <28.15%> (?)
total 13.82% <ø> (+<0.01%) ⬆️ Carriedforward from ce1255a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ner/include/behavior_path_planner/data_manager.hpp 37.50% <ø> (ø)
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...nner/include/behavior_path_planner/utils/utils.hpp 45.45% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 19.72% <0.00%> (-0.03%) ⬇️
...er/src/scene_module/avoidance/avoidance_module.cpp 3.67% <0.00%> (-0.01%) ⬇️
.../scene_module/goal_planner/goal_planner_module.cpp 5.67% <0.00%> (-0.32%) ⬇️
...th_planner/src/scene_module/lane_change/normal.cpp 6.74% <0.00%> (ø)
...nner/src/scene_module/pull_out/pull_out_module.cpp 3.72% <0.00%> (ø)
.../src/scene_module/side_shift/side_shift_module.cpp 10.83% <0.00%> (-0.06%) ⬇️
...path_planner/src/utils/pull_out/shift_pull_out.cpp 3.60% <0.00%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/expand-hatched-road-markings branch from 0094a4b to c3d7e5b Compare May 9, 2023 02:29
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/expand-hatched-road-markings branch from c3d7e5b to 086f31f Compare May 9, 2023 05:15
@takayuki5168 takayuki5168 merged commit fed3595 into autowarefoundation:main May 9, 2023
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request May 10, 2023
…undation#3604)

* expand hatched road markings

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add a flag

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix static_centerline_optimizer

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 deleted the feat/expand-hatched-road-markings branch May 13, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants