-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): expand hatched road markings #3604
feat(behavior_path_planner): expand hatched road markings #3604
Conversation
Can you please describe it in the autoware ll2 extension documentation? |
c366613
to
a71df29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove avoidance_by_lc directory?
It is removed by #3632.
planning/behavior_path_planner/src/scene_module/avoidance_by_lc/module.cpp
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3604 +/- ##
==========================================
- Coverage 14.69% 14.68% -0.02%
==========================================
Files 1297 1297
Lines 92187 92498 +311
Branches 29147 29355 +208
==========================================
+ Hits 13550 13583 +33
- Misses 63980 64228 +248
- Partials 14657 14687 +30
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3604 +/- ##
========================================
Coverage 13.82% 13.82%
========================================
Files 1395 1395
Lines 98083 98367 +284
Branches 29155 29339 +184
========================================
+ Hits 13556 13598 +42
- Misses 69872 70073 +201
- Partials 14655 14696 +41
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
0094a4b
to
c3d7e5b
Compare
c3d7e5b
to
086f31f
Compare
…undation#3604) * expand hatched road markings Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * add a flag Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix static_centerline_optimizer Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Description
Currently, we cannot utilize the area of hatched road markings for obstacle avoidance.
In the following discussion, the area of hatched road markings is defined, and with this PR we can expand the drivable area with the area of hatched road markings.
https://github.com/orgs/autowarefoundation/discussions/3414
launcher PR: autowarefoundation/autoware_launch#337
code change
enable_expanding_hatched_road_markings
in DrivableAreaInfouse_hatched_road_markings
ros parameters.generateDrivableArea
function.enable_expanding_hatched_road_markings
is set to false.result
exampl1
In the above figure, the yellow polygon is the hatched road markings.
example2
In the above figure, the yellow polygon is the hatched road markings.
Tests performed
planning simulator
Effects on system behavior
Can use hatched road markings for obstacle avoidance
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.