-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): run fixed_goal_planner with other modules simutaneously #3574
Conversation
1628365
to
1d8eb0e
Compare
1d8eb0e
to
5699634
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3574 +/- ##
==========================================
+ Coverage 14.11% 14.17% +0.06%
==========================================
Files 1394 1397 +3
Lines 97800 98617 +817
Branches 28980 29610 +630
==========================================
+ Hits 13801 13979 +178
- Misses 69348 69774 +426
- Partials 14651 14864 +213
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…s simutaneously Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
5699634
to
c41a27e
Compare
@kosuke55 Could you fix build error and re-run evaluator? |
@satoshi-ota |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
blinkers problem will happen after merging this PR, @purewater0901 will check it. |
…s simutaneously (autowarefoundation#3574) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Description
enable running
goal_planner
with other modules ONLY when goal is fixed.goal_planner_avoidance-2023-04-28_18.25.09.mp4
TODO:
if goal is allowed modification,
goal_planner
(pull_over) can not be run with other modules.we need to deal with this in the future.
goal_planner_avoidance_pull_over-2023-04-28_18.26.18.mp4
Related links
Tests performed
psim
wip tier4 internal scenario test
Notes for reviewers
Interface changes
no
Effects on system behavior
goal_planner
can run with other modules simutaneously ONLY when the goal is fixed.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.