Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): run fixed_goal_planner with other modules simutaneously #3574

Merged
merged 1 commit into from
May 8, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Apr 28, 2023

Description

enable running goal_planner with other modules ONLY when goal is fixed.

goal_planner_avoidance-2023-04-28_18.25.09.mp4

TODO:
if goal is allowed modification, goal_planner (pull_over) can not be run with other modules.
we need to deal with this in the future.

goal_planner_avoidance_pull_over-2023-04-28_18.26.18.mp4

Related links

Tests performed

psim
wip tier4 internal scenario test

Notes for reviewers

Interface changes

no

Effects on system behavior

goal_planner can run with other modules simutaneously ONLY when the goal is fixed.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 28, 2023
@kosuke55 kosuke55 force-pushed the feat/fixed_goal_planner_simutaneously branch 2 times, most recently from 1628365 to 1d8eb0e Compare April 28, 2023 09:40
@kosuke55 kosuke55 force-pushed the feat/fixed_goal_planner_simutaneously branch from 1d8eb0e to 5699634 Compare April 28, 2023 09:49
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 36.36% and project coverage change: +0.06 🎉

Comparison is base (eeaff15) 14.11% compared to head (c41a27e) 14.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3574      +/-   ##
==========================================
+ Coverage   14.11%   14.17%   +0.06%     
==========================================
  Files        1394     1397       +3     
  Lines       97800    98617     +817     
  Branches    28980    29610     +630     
==========================================
+ Hits        13801    13979     +178     
- Misses      69348    69774     +426     
- Partials    14651    14864     +213     
Flag Coverage Δ *Carryforward flag
differential 15.48% <36.36%> (?)
total 14.11% <ø> (-0.01%) ⬇️ Carriedforward from eeaff15

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../scene_module/goal_planner/goal_planner_module.hpp 100.00% <ø> (ø)
.../utils/goal_planner/default_fixed_goal_planner.hpp 100.00% <ø> (+100.00%) ⬆️
.../scene_module/goal_planner/goal_planner_module.cpp 14.94% <12.50%> (+0.16%) ⬆️
.../utils/goal_planner/default_fixed_goal_planner.cpp 58.06% <40.00%> (+0.92%) ⬆️
...ner/utils/goal_planner/fixed_goal_planner_base.hpp 66.66% <50.00%> (ø)
...th_planner/scene_module/scene_module_interface.hpp 35.87% <100.00%> (+1.76%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

…s simutaneously

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feat/fixed_goal_planner_simutaneously branch from 5699634 to c41a27e Compare April 29, 2023 07:30
@satoshi-ota
Copy link
Contributor

@kosuke55 Could you fix build error and re-run evaluator?

@kosuke55
Copy link
Contributor Author

@satoshi-ota
oh, thanks, update repos and rerun evaluator!

Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55
Copy link
Contributor Author

kosuke55 commented May 8, 2023

blinkers problem will happen after merging this PR, @purewater0901 will check it.

@kosuke55 kosuke55 merged commit 8b79207 into main May 8, 2023
@kosuke55 kosuke55 deleted the feat/fixed_goal_planner_simutaneously branch May 8, 2023 02:38
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
…s simutaneously (autowarefoundation#3574)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants