Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(behavior_path_planner): remove open cv dependency #3563

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Apr 27, 2023

Description

Currently, the behavior path planner does not depend on OpenCV.
I removed the dependency from the code.

Tests performed

planning simulator works well

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 27, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review April 27, 2023 04:45
@takayuki5168 takayuki5168 enabled auto-merge (squash) April 27, 2023 05:12
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e7f8c12) 14.07% compared to head (b545073) 14.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3563   +/-   ##
=======================================
  Coverage   14.07%   14.07%           
=======================================
  Files        1398     1398           
  Lines       97963    97963           
  Branches    29085    29085           
=======================================
  Hits        13789    13789           
  Misses      69501    69501           
  Partials    14673    14673           
Flag Coverage Δ *Carryforward flag
differential 15.34% <100.00%> (?)
total 14.07% <ø> (-0.01%) ⬇️ Carriedforward from e7f8c12

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nner/include/behavior_path_planner/utils/utils.hpp 45.45% <ø> (ø)
planning/behavior_path_planner/test/input.cpp 57.57% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit 4422d33 into autowarefoundation:main Apr 27, 2023
@takayuki5168 takayuki5168 deleted the chore/behavior-path-remove-cv-dependency branch April 27, 2023 05:27
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
…dation#3563)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants