Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(intersection): fix dying node #3555

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Apr 26, 2023

Description

Without this PR, in some cases, the intersection module dies due to nullpointer access.

Tests performed

planning simulator

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 26, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review April 26, 2023 16:26
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c8a889e) 14.07% compared to head (fe9407a) 14.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3555   +/-   ##
=======================================
  Coverage   14.07%   14.07%           
=======================================
  Files        1398     1398           
  Lines       97964    97962    -2     
  Branches    29084    29085    +1     
=======================================
  Hits        13790    13790           
+ Misses      69502    69500    -2     
  Partials    14672    14672           
Flag Coverage Δ *Carryforward flag
differential 3.45% <0.00%> (?)
total 14.07% <ø> (+<0.01%) ⬆️ Carriedforward from c8a889e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ier4_planning_rviz_plugin/include/path/display.hpp 0.00% <ø> (ø)
...c/scene_module/intersection/scene_intersection.cpp 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit e7f8c12 into autowarefoundation:main Apr 26, 2023
@takayuki5168 takayuki5168 deleted the fix/intersection-node-die2 branch April 26, 2023 20:24
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant