Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): add guard for minimum lane changing velocity #3545

Merged
merged 4 commits into from
Apr 26, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Apr 26, 2023

Description

Since users can set minimum_lane_changing_velocity to any desired values, it can cause some potential issues. In the current lane change module, it does not allow the ego vehicle to accelerate while performing lane change. However, if the minimum_lane_changing_velocity becomes larger than it can reach on the prepare section, it needs to accelerate during the lane change phase. In this PR, I set a guard for the maximum value for the parameter as

minimum_lane_changing_velocity = min(parameter.minimum_lane_changing_velocity, a_{acc} * t_{prepare})

Tests performed

TIER IV Internal Link
Scenario Result 1328/1330

Effects on system behavior

When the user sets large values for the minimum lane changing velocity, this change will prevent it from having large values.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 26, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage: 12.50% and project coverage change: -0.83 ⚠️

Comparison is base (ea7bcbe) 14.97% compared to head (50f659a) 14.14%.

❗ Current head 50f659a differs from pull request most recent head 251eb7c. Consider uploading reports for the commit 251eb7c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3545      +/-   ##
==========================================
- Coverage   14.97%   14.14%   -0.83%     
==========================================
  Files        1301     1413     +112     
  Lines       92043    98943    +6900     
  Branches    29044    29585     +541     
==========================================
+ Hits        13782    13996     +214     
- Misses      63586    70128    +6542     
- Partials    14675    14819     +144     
Flag Coverage Δ *Carryforward flag
differential 15.43% <12.50%> (?)
total 14.08% <ø> (-0.89%) ⬇️ Carriedforward from 8825b96

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nner/utils/lane_change/lane_change_module_data.hpp 0.00% <ø> (ø)
...lanner/src/scene_module/avoidance_by_lc/module.cpp 0.00% <0.00%> (ø)
...planner/src/scene_module/lane_change/bt_normal.cpp 13.95% <0.00%> (-0.34%) ⬇️
...avior_path_planner/src/utils/lane_change/utils.cpp 0.69% <0.00%> (ø)
...th_planner/src/scene_module/lane_change/normal.cpp 6.00% <16.66%> (+0.31%) ⬆️
...or_path_planner/src/behavior_path_planner_node.cpp 19.79% <33.33%> (+0.13%) ⬆️

... and 124 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901 purewater0901 merged commit 47349f6 into main Apr 26, 2023
@purewater0901 purewater0901 deleted the feat/add-gurad-for-min-lc-vel branch April 26, 2023 13:44
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
…city (autowarefoundation#3545)

* refactor(behavior_path_planner): remove dupliated lane change parameters

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(behavior_path_planner): add guard for minimum lane changing velocity

Signed-off-by: yutaka <purewater0901@gmail.com>

---------

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants