-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(lane_change): move for lane change module to interface #3536
Merged
zulfaqar-azmi-t4
merged 3 commits into
autowarefoundation:main
from
zulfaqar-azmi-t4:refactor-lc-module-interface
Apr 27, 2023
Merged
refactor(lane_change): move for lane change module to interface #3536
zulfaqar-azmi-t4
merged 3 commits into
autowarefoundation:main
from
zulfaqar-azmi-t4:refactor-lc-module-interface
Apr 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Apr 26, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3536 +/- ##
=======================================
Coverage 14.96% 14.96%
=======================================
Files 1300 1300
Lines 92131 92186 +55
Branches 29099 29127 +28
=======================================
+ Hits 13787 13798 +11
- Misses 63670 63715 +45
+ Partials 14674 14673 -1
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
zulfaqar-azmi-t4
force-pushed
the
refactor-lc-module-interface
branch
from
April 27, 2023 03:08
5dff0a5
to
e777dd3
Compare
zulfaqar-azmi-t4
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
a team
as code owners
April 27, 2023 03:16
zulfaqar-azmi-t4
force-pushed
the
refactor-lc-module-interface
branch
from
April 27, 2023 03:16
e777dd3
to
8985016
Compare
Additional degradation check |
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4
force-pushed
the
refactor-lc-module-interface
branch
from
April 27, 2023 06:44
8985016
to
274abd0
Compare
purewater0901
approved these changes
Apr 27, 2023
Mingyu1991
pushed a commit
to Mingyu1991/autoware.universe
that referenced
this pull request
Jun 26, 2023
…warefoundation#3536) * refactor(lane_change): move for lane change module to interface Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix build error Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix conflict --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the lane change module of the behavior path planner to use behavior trees instead of the previous implementation. The PR moves
bt_normal
's content tonormal
and a introduces new classLaneChangeBTModule
that inherits from theLaneChangeInterface
and holds a normal lane change behavior tree object. It also improves the maintainability and style of some of the existing classes and removes some unnecessary header file inclusions and files.Related links
None.
Tests performed
COMPILE_WITH_OLD_ARCHITECTURE=FALSE
COMPILE_WITH_OLD_ARCHITECTURE=TRUE
Notes for reviewers
lane_change_module.cpp
will be removed.LaneChangeModule
toLaneChangeBTModule
, the actual name of the bt leave will remainLaneChangeModule
.Interface changes
None
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.