test(pointcloud_preprocessor): add test for launch & publish (for both use_imu=true/false) #3476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kminoda <koji.minoda@tier4.jp>
kminoda
requested review from
amc-nu,
miursh,
yukkysaito and
a team
as code owners
github-actions
bot
added
the
component:sensing
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3476 +/- ##
=======================================
Coverage 14.45% 14.45%
=======================================
Files 1456 1456
Lines 102537 102537
Branches 29652 29652
=======================================
Hits 14819 14819
Misses 71567 71567
Partials 16151 16151
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: kminoda <koji.minoda@tier4.jp>
|
Confirmed that this solves the above-mentioned issue in our real robot |
kminoda
changed the title
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
kminoda
changed the title
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
miursh
approved these changes
Jul 12, 2023
kminoda
deleted the
fix/distortion_corrector/debug_when_use_imu_is_false
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add test for distortion_corrector.
(Originally I created this PR to fix an issue mentioned in this discussion, which was already addressed in another PR (by accident?). So instead of adding this change, I just would like to add a test that I created for the original PR)
Related links
https://github.com/orgs/autowarefoundation/discussions/3441
Tests performed
ROS2 unittest has been performed in this CI.
Notes for reviewers
N/A
Interface changes
None
Effects on system behavior
None (Improved when
use_imuis set False)Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.