Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(map_loader): add a ROS 2 test #3170

Merged

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Mar 27, 2023

Description

Mostly written by ChatGPT

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@github-actions github-actions bot added the component:map Map creation, storage, and loading. (auto-assigned) label Mar 27, 2023
pre-commit-ci bot and others added 3 commits March 27, 2023 03:54
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda self-assigned this Mar 27, 2023
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda changed the title chore(map_loader): add a ROS 2 test chore(map_loader): add a ROS 2 test with ChatGPT Mar 27, 2023
@kminoda kminoda changed the title chore(map_loader): add a ROS 2 test with ChatGPT chore(map_loader): add a ROS 2 test Mar 27, 2023
@kminoda kminoda marked this pull request as ready for review March 27, 2023 05:27
@kminoda kminoda requested review from mitsudome-r, RyuYamamoto and a team as code owners March 27, 2023 05:27
@kminoda kminoda changed the title chore(map_loader): add a ROS 2 test test(map_loader): add a ROS 2 test Mar 27, 2023
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage: 52.47% and project coverage change: +0.09 🎉

Comparison is base (7a72116) 12.32% compared to head (7fc8d32) 12.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3170      +/-   ##
==========================================
+ Coverage   12.32%   12.41%   +0.09%     
==========================================
  Files        1340     1343       +3     
  Lines       93408    93510     +102     
  Branches    26754    26805      +51     
==========================================
+ Hits        11509    11609     +100     
+ Misses      69745    69661      -84     
- Partials    12154    12240      +86     
Flag Coverage Δ *Carryforward flag
differential 33.33% <52.47%> (?)
total 12.32% <ø> (ø) Carriedforward from 12da660

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...tcloud_map_loader/pointcloud_map_loader_module.cpp 20.00% <ø> (+20.00%) ⬆️
..._loader/test/test_pointcloud_map_loader_module.cpp 45.45% <45.45%> (ø)
...oader/test/test_differential_map_loader_module.cpp 55.17% <55.17%> (ø)
...map_loader/test/test_partial_map_loader_module.cpp 60.71% <60.71%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@RyuYamamoto RyuYamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda merged commit b63806b into autowarefoundation:main Mar 27, 2023
@kminoda kminoda deleted the chore/add_test_for_map_loader branch March 29, 2023 07:21
swiftfile pushed a commit to swiftfile/autoware.universe that referenced this pull request Mar 29, 2023
* chore(map_loader): add a ROS 2 test

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* debug

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* added other tests too

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* fix pre-commit

Signed-off-by: kminoda <koji.minoda@tier4.jp>

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Yusuke Mizoguchi <sky.y.m.318@gmail.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Apr 4, 2023
* chore(map_loader): add a ROS 2 test

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* debug

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* added other tests too

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* fix pre-commit

Signed-off-by: kminoda <koji.minoda@tier4.jp>

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:map Map creation, storage, and loading. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants