-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(map_loader): add a ROS 2 test #3170
test(map_loader): add a ROS 2 test #3170
Conversation
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3170 +/- ##
==========================================
+ Coverage 12.32% 12.41% +0.09%
==========================================
Files 1340 1343 +3
Lines 93408 93510 +102
Branches 26754 26805 +51
==========================================
+ Hits 11509 11609 +100
+ Misses 69745 69661 -84
- Partials 12154 12240 +86
*This pull request uses carry forward flags. Click here to find out more.
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* chore(map_loader): add a ROS 2 test Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * debug Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * added other tests too Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * fix pre-commit Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Yusuke Mizoguchi <sky.y.m.318@gmail.com>
* chore(map_loader): add a ROS 2 test Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * debug Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * added other tests too Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * fix pre-commit Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Mostly written by ChatGPT
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.