Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(diagnostic_converter): remove unit and blank in the value #3151

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Mar 23, 2023

Description

Removed the unit and the blank if they exist in the value of diagnostics.

I confirmed that diagnostics with the unit works well with the scenario simulator v2 via diagnostic_converter.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) label Mar 23, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review March 23, 2023 06:00
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (cf753f4) 13.14% compared to head (c8e599b) 13.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3151   +/-   ##
=======================================
  Coverage   13.14%   13.14%           
=======================================
  Files        1239     1239           
  Lines       87524    87535   +11     
  Branches    26744    26750    +6     
=======================================
+ Hits        11502    11509    +7     
- Misses      63871    63872    +1     
- Partials    12151    12154    +3     
Flag Coverage Δ *Carryforward flag
differential 37.11% <50.00%> (?)
total 13.14% <ø> (+<0.01%) ⬆️ Carriedforward from cf753f4

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...luator/diagnostic_converter/src/converter_node.cpp 58.33% <50.00%> (+2.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit aa2f265 into autowarefoundation:main Mar 23, 2023
@takayuki5168 takayuki5168 deleted the feat/diagnostic-remove-unit branch March 23, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:evaluator Evaluation tools for planning, localization etc. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants