Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(intersection): display intersection marker only when stopped #3150

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Mar 23, 2023

Description

Fixed the problem that the intersection module displays a stop line at the origin when there is no need to stop.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <hilo.soblin@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 23, 2023
@soblin
Copy link
Contributor Author

soblin commented Mar 23, 2023

@kyoichi-sugahara This is an additional fix for #2506

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf753f4) 13.14% compared to head (466a501) 13.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3150   +/-   ##
=======================================
  Coverage   13.14%   13.14%           
=======================================
  Files        1239     1239           
  Lines       87524    87524           
  Branches    26744    26744           
=======================================
  Hits        11502    11502           
  Misses      63871    63871           
  Partials    12151    12151           
Flag Coverage Δ *Carryforward flag
differential 3.91% <0.00%> (?)
total 13.14% <ø> (+<0.01%) ⬆️ Carriedforward from cf753f4

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ty_planner/src/scene_module/intersection/debug.cpp 0.00% <0.00%> (ø)
...c/scene_module/intersection/scene_intersection.cpp 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soblin soblin merged commit e0e2a60 into autowarefoundation:main Mar 24, 2023
@soblin soblin deleted the chore/fix-intersection-stop-line-origin branch April 24, 2023 13:14
soblin added a commit to soblin/autoware.universe that referenced this pull request May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants