Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(probablistic_occupancy_grid_map): add grid map fusion node to fuse multiple sensor based occupancy grid map #3107

Closed
wants to merge 36 commits into from

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Mar 17, 2023

Description

Related Issue:

Goal

This PR aims to change occupancy grid map generation flow like following figures:

Current Final goal
image image

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

YoshiRi added 9 commits March 17, 2023 02:39
add scan_frame and raytrace center

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
and fix missing }

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@github-actions github-actions bot added component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Mar 17, 2023
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 5.89% and project coverage change: -0.19 ⚠️

Comparison is base (2a23a4b) 11.92% compared to head (ea6f28f) 11.73%.

❗ Current head ea6f28f differs from pull request most recent head eb8e7b5. Consider uploading reports for the commit eb8e7b5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3107      +/-   ##
==========================================
- Coverage   11.92%   11.73%   -0.19%     
==========================================
  Files        1334     1349      +15     
  Lines       92928    94818    +1890     
  Branches    24729    24800      +71     
==========================================
+ Hits        11078    11131      +53     
- Misses      70370    72172    +1802     
- Partials    11480    11515      +35     
Flag Coverage Δ *Carryforward flag
differential 1.01% <5.89%> (?)
total 11.93% <ø> (+0.01%) ⬆️ Carriedforward from b091c33

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...pancy_grid_map/src/fusion/grid_map_fusion_node.cpp 0.00% <0.00%> (ø)
...d_map/pointcloud_based_occupancy_grid_map_node.cpp 0.00% <ø> (ø)
...atenate_data/concatenate_and_time_sync_nodelet.hpp 0.00% <ø> (ø)
...essor/concatenate_data/concatenate_pointclouds.hpp 0.00% <0.00%> (ø)
...or/time_synchronizer/time_synchronizer_nodelet.hpp 0.00% <0.00%> (ø)
...atenate_data/concatenate_and_time_sync_nodelet.cpp 0.00% <0.00%> (ø)
...r/src/concatenate_data/concatenate_pointclouds.cpp 0.00% <0.00%> (ø)
...rc/time_synchronizer/time_synchronizer_nodelet.cpp 0.00% <0.00%> (ø)
..._map/include/fusion/single_frame_fusion_policy.hpp 29.00% <29.00%> (ø)
...tic_occupancy_grid_map/test/fusion_policy_test.cpp 31.25% <31.25%> (ø)
... and 2 more

... and 12 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

YoshiRi added 6 commits March 20, 2023 11:44
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Apr 3, 2023
YoshiRi added 8 commits April 4, 2023 04:37
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
YoshiRi added 2 commits April 10, 2023 17:48
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
YoshiRi added 11 commits April 11, 2023 09:40
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Apr 22, 2023
@stale
Copy link

stale bot commented Jul 28, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jul 28, 2023
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Oct 5, 2023
Copy link

stale bot commented Dec 4, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Dec 4, 2023
@YoshiRi YoshiRi closed this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) status:stale Inactive or outdated issues. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Update occupancy grid map frame to gain longer range visibility in the intersection
1 participant