Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-origanize launch file for probabilisitic_occupancy_grid_map packages #3045

Closed
3 tasks done
YoshiRi opened this issue Mar 10, 2023 · 12 comments
Closed
3 tasks done
Assignees
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) status:stale Inactive or outdated issues. (auto-assigned)

Comments

@YoshiRi
Copy link
Contributor

YoshiRi commented Mar 10, 2023

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

Try to reorganize launch file for occuapncy grid map generation.

Purpose

Problem Statements

  • There are duplicated launch files in tier4_perception_launch and probabilisitic_occupancy_grid_map packages.
    • This is confusing for users which file to edit
  • poor readability because of launch.py style
    • It's better to rewrite launch file in xml file
    • or create organizer launch to access each launch.py files

Possible approaches

  • Create origanizer launch.xml in tier4_perception_launch instead of current launch.py
    • From the launch.xml file, call launch.py in probabilistic_occupancy_grid_map packages.
    • Switchable between potincloud/laserscan based methods

Definition of done

Reproduce the same behavior

@YoshiRi YoshiRi added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Mar 10, 2023
@mitsudome-r
Copy link
Member

@YoshiRi
@Zeysthingz is willing to help with this task. @Zeysthingz Could you describe your approach (or create a draft PR) and align with @YoshiRi about this task?

@YoshiRi
Copy link
Contributor Author

YoshiRi commented Mar 14, 2023

@mitsudome-r @Zeysthingz
OK. Where should we discuss? I'll just describe my load map here.

@Zeysthingz
Copy link
Contributor

I did not examine the issue in detail yet but I think we can discuss on discord if it's fine.

@YoshiRi
Copy link
Contributor Author

YoshiRi commented Mar 14, 2023

My goal

As described in #2906, I think we need to create occupancy grid map in each sensor frame to correctly reflect the FOV of the sensor.

So, my goal image is like following figures:

Current Final goal
image image

Sub Goals

To achieve the goal, I think there should be some sub goals to be achieved.

  • <1> Fix grid map generation
    • a. need to generate same grid map for fusion but different scan frame
    • b. manage each sensor FOV correctly
    • c. launch refactoring
  • <2> Add fusion node
    • a. asyncronous grid map fusion with [[Binary Bayes/ Linear Opinion Pool/ Dempster-Shafer]]

Related PRs

@YoshiRi
Copy link
Contributor Author

YoshiRi commented Mar 14, 2023

I did not examine the issue in detail yet but I think we can discuss on discord if it's fine.

@Zeysthingz Fine, but I am not familiar with discord (just used for chat with friends), could you guide me?

@Zeysthingz
Copy link
Contributor

Yes sure I can ,we usually use discord for company stuffs. zeys#0531 is me you can add me.

@YoshiRi
Copy link
Contributor Author

YoshiRi commented Mar 14, 2023

I just created talk room.
/< I removed URL and ID. Please mention me again if you need this information/> .

@stale
Copy link

stale bot commented May 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label May 15, 2023
@xmfcx xmfcx assigned YoshiRi and unassigned Zeysthingz May 31, 2023
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label May 31, 2023
@stale
Copy link

stale bot commented Jul 30, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jul 30, 2023
@idorobotics
Copy link

idorobotics commented Oct 4, 2023

My goal

As described in #2906, I think we need to create occupancy grid map in each sensor frame to correctly reflect the FOV of the sensor.

So, my goal image is like following figures:
Current Final goal
image image

Sub Goals

To achieve the goal, I think there should be some sub goals to be achieved.

* <1> Fix grid map generation
  
  * a. need to generate same grid map for fusion but different scan frame
  * b. manage each sensor FOV correctly
  * c. launch refactoring

* <2> Add fusion node
  
  * a. asyncronous grid map fusion with [[Binary Bayes/ Linear Opinion Pool/ Dempster-Shafer]]

Related PRs

* 1.a: Separate grid map origin and scan origin :
  
  * [feat(probablistic_occupancy_grid_map): add alternative to gridmap origin frame #2939](https://github.com/autowarefoundation/autoware.universe/pull/2939)

* 1.b: Filter the obstacle pointcloud by raw pointcloud to correctly reflect FOV:
  
  * [feat(probabilistic_occupancy_grid_map): add pointcloud filter in gridmap generation #3054](https://github.com/autowarefoundation/autoware.universe/pull/3054)

* 1.c: Refactor launch.xml

@YoshiRi Looks like all PRs are merged. Can this issue be closed or is there other work outstanding?

@idorobotics idorobotics moved this from Todo to In Progress in Sensing & Perception Working Group Oct 4, 2023
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Oct 4, 2023
Copy link

stale bot commented Dec 3, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@technolojin
Copy link
Contributor

I think this issue is good to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) status:stale Inactive or outdated issues. (auto-assigned)
Projects
No open projects
Development

No branches or pull requests

5 participants