-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_perception_launch): refactored occupancy_grid_map launcher #3058
feat(tier4_perception_launch): refactored occupancy_grid_map launcher #3058
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3058 +/- ##
==========================================
- Coverage 11.92% 11.91% -0.01%
==========================================
Files 1334 1334
Lines 92928 92928
Branches 24729 24729
==========================================
- Hits 11078 11076 -2
- Misses 70370 70371 +1
- Partials 11480 11481 +1
*This pull request uses carry forward flags. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
bb4c2cc
to
ac6fdb7
Compare
add scan_frame and raytrace center Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
ac6fdb7
to
467c89b
Compare
and fix missing } Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
73dab25
to
7095da9
Compare
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Description
This PR depends on #3032.
Enable to user to switch pointcloud-based and laserscan-based method in single argument.
This results in shorter descriptions and method change in minimum fixes.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.