Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pointcloud_preprocessor): pointcloud preprocessor pcl headers #3073

Merged
merged 3 commits into from
Mar 14, 2023
Merged

fix(pointcloud_preprocessor): pointcloud preprocessor pcl headers #3073

merged 3 commits into from
Mar 14, 2023

Conversation

drwnz
Copy link
Contributor

@drwnz drwnz commented Mar 14, 2023

Description

Before
When building using --packages-up-to, the build fails with a missing header file.

After
Build passes.

Environment: This issue occurred when building the TLR software stack and dependent packages (--packages-up-to jetson_tlr_launch in Humble).
PCL version: 1.12.1

Apologies, because of an issue with the original branch on my fork I had to re-create this PR (originally approved at #3070)

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

drwnz added 2 commits March 14, 2023 12:37
Signed-off-by: David Wong <david.wong@tier4.jp>
Signed-off-by: David Wong <david.wong@tier4.jp>
@drwnz drwnz requested review from amc-nu, miursh, yukkysaito and a team as code owners March 14, 2023 03:46
@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Mar 14, 2023
@drwnz drwnz changed the title Fix/pointcloud preprocessor headers fix(pointcloud_preprocessor): pointcloud preprocessor pcl headers Mar 14, 2023
@drwnz drwnz enabled auto-merge (squash) March 14, 2023 03:47
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drwnz drwnz merged commit d19c6c4 into autowarefoundation:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants