Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_departure_checker): use kinematic state for ego pose #3057

Conversation

takayuki5168
Copy link
Contributor

Description

Use kinematic state for ego pose instead of tf.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Mar 11, 2023
@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.28 ⚠️

Comparison is base (279e434) 11.93% compared to head (9fdcb74) 11.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3057      +/-   ##
==========================================
- Coverage   11.93%   11.66%   -0.28%     
==========================================
  Files        1321     1321              
  Lines       91938    94084    +2146     
  Branches    24525    26081    +1556     
==========================================
+ Hits        10974    10975       +1     
- Misses      69605    71569    +1964     
- Partials    11359    11540     +181     
Flag Coverage Δ *Carryforward flag
differential 5.32% <0.00%> (?)
total 11.93% <ø> (+<0.01%) ⬆️ Carriedforward from 279e434

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../lane_departure_checker/lane_departure_checker.hpp 0.00% <ø> (ø)
..._departure_checker_node/lane_departure_checker.cpp 0.00% <0.00%> (ø)
...rture_checker_node/lane_departure_checker_node.cpp 0.29% <0.00%> (+<0.01%) ⬆️

... and 13 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 marked this pull request as ready for review March 13, 2023 04:37
@takayuki5168 takayuki5168 requested review from kyoichi-sugahara and a team as code owners March 13, 2023 04:37
@takayuki5168
Copy link
Contributor Author

@kyoichi-sugahara Could you review the PR?

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168 takayuki5168 merged commit 5e29ea0 into autowarefoundation:main Mar 14, 2023
@takayuki5168 takayuki5168 deleted the fix/use-kinematic-state-for-ego-pose branch March 14, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants