Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): use efficient lateral distance calculation #3041

Merged
merged 6 commits into from
Mar 14, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Mar 9, 2023

Description

Use more efficient function to compute lateral distance computation.

The results are

Old Computation time: 29345[ns]
New Computation time: 27284[ns]

It almost 10% faster than previous one

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (0d4e444) 11.86% compared to head (cd64e9a) 11.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3041      +/-   ##
==========================================
- Coverage   11.86%   11.86%   -0.01%     
==========================================
  Files        1333     1333              
  Lines       92786    92792       +6     
  Branches    24649    24654       +5     
==========================================
  Hits        11011    11011              
- Misses      70364    70370       +6     
  Partials    11411    11411              
Flag Coverage Δ *Carryforward flag
differential 5.55% <0.00%> (?)
total 11.86% <ø> (+<0.01%) ⬆️ Carriedforward from 0d4e444

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/include/behavior_path_planner/utilities.hpp 23.80% <ø> (ø)
...ehavior_path_planner/src/util/lane_change/util.cpp 0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utilities.cpp 7.54% <0.00%> (-0.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901 purewater0901 changed the title feat(behavior_path_planner): remove unnecessary condition feat(behavior_path_planner): use efficient lateral distance calculation Mar 10, 2023
Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901
Copy link
Contributor Author

evaluator 882/882

@purewater0901
Copy link
Contributor Author

@zulfaqar-azmi-t4
Copy link
Contributor

Seems like there is some issues when computing the lane change path under curved situation.

This is the result before PR

before.PR.mp4

This is the result after PR

after.PR.mp4

@purewater0901
Copy link
Contributor Author

@zulfaqar-azmi-t4

I tried quite a few times, but I couldn't reproduce your bags

drivable_area_rviz_plugin-2023-03-13_12.23.06.mp4

@zulfaqar-azmi-t4
Copy link
Contributor

@purewater0901
Yes, I can't reproduce in my home setup as well.

@purewater0901 purewater0901 merged commit ad413be into main Mar 14, 2023
@purewater0901 purewater0901 deleted the feat/clean-lane-change-code branch March 14, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants