-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): use efficient lateral distance calculation #3041
Conversation
Signed-off-by: yutaka <purewater0901@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3041 +/- ##
==========================================
- Coverage 11.86% 11.86% -0.01%
==========================================
Files 1333 1333
Lines 92786 92792 +6
Branches 24649 24654 +5
==========================================
Hits 11011 11011
- Misses 70364 70370 +6
Partials 11411 11411
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
evaluator 882/882 |
Seems like there is some issues when computing the lane change path under curved situation. This is the result before PR before.PR.mp4This is the result after PR after.PR.mp4 |
I tried quite a few times, but I couldn't reproduce your bags drivable_area_rviz_plugin-2023-03-13_12.23.06.mp4 |
@purewater0901 |
Description
Use more efficient function to compute lateral distance computation.
The results are
It almost 10% faster than previous one
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.