-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(costmap_generator): wait for lanelet map #2765
Conversation
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Codecov ReportBase: 11.65% // Head: 12.42% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2765 +/- ##
==========================================
+ Coverage 11.65% 12.42% +0.77%
==========================================
Files 1312 1212 -100
Lines 91464 85709 -5755
Branches 24346 24328 -18
==========================================
- Hits 10661 10651 -10
+ Misses 69669 63942 -5727
+ Partials 11134 11116 -18
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! By the way, how about adding someone to the package maintainers?
@kenji-miyake |
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 kosuke.tnp@gmail.com
Description
Accessing
lanelet_map_
before it is set causes that node dies.ex) In the following situation I observed the problem
const auto all_parking_lots = lanelet::utils::query::getAllParkingLots(lanelet_map_ptr);
(f 2)Related links
Tests performed
psim
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.