Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(costmap_generator): wait for lanelet map #2765

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jan 27, 2023

Signed-off-by: kosuke55 kosuke.tnp@gmail.com

Description

Accessing lanelet_map_ before it is set causes that node dies.

ex) In the following situation I observed the problem

  • set initial ego vehicle in parking_space
  • activate_by_scenario: False

const auto all_parking_lots = lanelet::utils::query::getAllParkingLots(lanelet_map_ptr); (f 2)
image

Related links

Tests performed

psim

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

  • I've confirmed the [contribution guidelines].
  • The PR follows the [pull request guidelines].

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the [pull request guidelines].
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 requested review from kenji-miyake and a team as code owners January 27, 2023 14:11
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 27, 2023
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 11.65% // Head: 12.42% // Increases project coverage by +0.77% 🎉

Coverage data is based on head (5152061) compared to base (75ae084).
Patch coverage: 10.63% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2765      +/-   ##
==========================================
+ Coverage   11.65%   12.42%   +0.77%     
==========================================
  Files        1312     1212     -100     
  Lines       91464    85709    -5755     
  Branches    24346    24328      -18     
==========================================
- Hits        10661    10651      -10     
+ Misses      69669    63942    -5727     
+ Partials    11134    11116      -18     
Flag Coverage Δ *Carryforward flag
differential 31.63% <0.00%> (?)
total 12.43% <10.63%> (+0.77%) ⬆️ Carriedforward from d3e5714

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../scene_module/utils/geometric_parallel_parking.hpp 0.00% <ø> (ø)
...r/src/scene_module/pull_out/geometric_pull_out.cpp 0.00% <0.00%> (ø)
...nner/src/scene_module/pull_out/pull_out_module.cpp 0.00% <0.00%> (ø)
...anner/src/scene_module/pull_out/shift_pull_out.cpp 0.00% <0.00%> (ø)
.../scene_module/utils/geometric_parallel_parking.cpp 0.00% <0.00%> (ø)
...nodes/costmap_generator/costmap_generator_node.cpp 0.00% <0.00%> (ø)
..._lateral_controller/src/mpc_lateral_controller.cpp 35.10% <29.41%> (ø)
...nal_controller/src/pid_longitudinal_controller.cpp 39.34% <0.00%> (-0.42%) ⬇️
...erception/traffic_light_classifier/src/nodelet.cpp 0.00% <0.00%> (ø)
... and 109 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! By the way, how about adding someone to the package maintainers?

@kosuke55
Copy link
Contributor Author

@kenji-miyake
Thaks for review! I will add maitainers.

@kosuke55 kosuke55 merged commit 45079b5 into autowarefoundation:main Jan 27, 2023
@kosuke55 kosuke55 deleted the fix/costmap_activate branch January 27, 2023 14:59
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Jan 30, 2023
lexavtanke pushed a commit to lexavtanke/autoware.universe that referenced this pull request Jan 31, 2023
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
asana17 pushed a commit to asana17/autoware.universe that referenced this pull request Feb 8, 2023
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Feb 14, 2023
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants