Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(motion_utils): fixed virtual wall marker to appear #2757

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Jan 27, 2023

Signed-off-by: Mamoru Sobue mamoru.sobue@tier4.jp

Description

Fixed virtual wall marker addition condition

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Jan 27, 2023
@soblin soblin marked this pull request as ready for review January 27, 2023 03:11
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 11.64% // Head: 11.64% // No change to project coverage 👍

Coverage data is based on head (c320b41) compared to base (3523270).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2757   +/-   ##
=======================================
  Coverage   11.64%   11.64%           
=======================================
  Files        1312     1312           
  Lines       91448    91448           
  Branches    24343    24343           
=======================================
  Hits        10650    10650           
+ Misses      69682    69681    -1     
- Partials    11116    11117    +1     
Flag Coverage Δ *Carryforward flag
differential 12.81% <0.00%> (?)
total 11.64% <0.00%> (ø) Carriedforward from 3523270

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
common/motion_utils/src/marker/marker_helper.cpp 15.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soblin soblin merged commit 0717cd4 into autowarefoundation:main Jan 27, 2023
@soblin soblin deleted the fix/virtual-wall-marker branch January 27, 2023 05:58
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Jan 30, 2023
lexavtanke pushed a commit to lexavtanke/autoware.universe that referenced this pull request Jan 31, 2023
…ation#2757)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
asana17 pushed a commit to asana17/autoware.universe that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants