fix(euclidean_cluster): keep pointcloud resolution in long-range for Euclidean cluster #2749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
github-actions
bot
added
the
component:perception
Codecov ReportBase: 11.54% // Head: 11.54% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2749 +/- ##
=======================================
Coverage 11.54% 11.54%
=======================================
Files 1309 1309
Lines 91355 91355
Branches 24247 24247
=======================================
Hits 10549 10549
Misses 69765 69765
Partials 11041 11041
*This pull request uses carry forward flags. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
badai-nguyen
changed the title
|
@badai-nguyen May I ask a little more background on the PR? |
@yukkysaito I am sorry for forgetting open discussion for this beforehand. |
|
@badai-nguyen Thank you. LGTM 👍 Also, can you update this figure? |
Merged
4 tasks
3 tasks
maxime-clem
pushed a commit
to maxime-clem/autoware.universe
that referenced
this pull request
Jan 30, 2023
…Euclidean cluster (autowarefoundation#2749) * fix: change downnsample split pipeline Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: add downsample range params Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: revise disuse map_filter case Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
lexavtanke
pushed a commit
to lexavtanke/autoware.universe
that referenced
this pull request
Jan 31, 2023
…Euclidean cluster (autowarefoundation#2749) * fix: change downnsample split pipeline Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: add downsample range params Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: revise disuse map_filter case Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
badai-nguyen
added a commit
to badai-nguyen/autoware.universe
that referenced
this pull request
Feb 2, 2023
…Euclidean cluster (autowarefoundation#2749) * fix: change downnsample split pipeline Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: add downsample range params Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: revise disuse map_filter case Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
asana17
pushed a commit
to asana17/autoware.universe
that referenced
this pull request
Feb 8, 2023
…Euclidean cluster (autowarefoundation#2749) * fix: change downnsample split pipeline Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: add downsample range params Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: revise disuse map_filter case Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
tkimura4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 23, 2023
…Euclidean cluster (autowarefoundation#2749) * fix: change downnsample split pipeline Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: add downsample range params Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: revise disuse map_filter case Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
7 tasks
tkimura4
added a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 23, 2023
…Euclidean cluster (autowarefoundation#2749) (#336) * fix: change downnsample split pipeline * fix: add downsample range params * fix: revise disuse map_filter case Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Co-authored-by: badai nguyen <94814556+badai-nguyen@users.noreply.github.com>
satoshi-ota
pushed a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
Jun 20, 2023
…Euclidean cluster (autowarefoundation#2749) (autowarefoundation#336) * fix: change downnsample split pipeline * fix: add downsample range params * fix: revise disuse map_filter case Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Co-authored-by: badai nguyen <94814556+badai-nguyen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR to reflect a suggestion for #2754
The background and computational cost evaluation also discussed here.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.