-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(raw_vehicle_cmd_converter): remove external command converter validation #2711
fix(raw_vehicle_cmd_converter): remove external command converter validation #2711
Conversation
…idation Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
@mkuri Would you check this PR? |
Codecov ReportBase: 11.57% // Head: 11.57% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2711 +/- ##
=======================================
Coverage 11.57% 11.57%
=======================================
Files 1302 1302
Lines 90790 90790
Branches 23970 23971 +1
=======================================
+ Hits 10511 10512 +1
Misses 69285 69285
+ Partials 10994 10993 -1
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…idation (autowarefoundation#2711) * fix(raw_vehicle_cmd_converter): remove external command converter validation Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> * chore: fix Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
…idation (autowarefoundation#2711) * fix(raw_vehicle_cmd_converter): remove external command converter validation Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> * chore: fix Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
…idation (autowarefoundation#2711) * fix(raw_vehicle_cmd_converter): remove external command converter validation Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> * chore: fix Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: taikitanaka3 taiki.tanaka@tier4.jp
Description
this PR resolve : #2710
for backward compatibility(change done by this PR)
for safety(same as before)
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.