Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(raw_vehicle_cmd_converter): remove external command converter validation #2711

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Jan 21, 2023

Signed-off-by: taikitanaka3 taiki.tanaka@tier4.jp

Description

this PR resolve : #2710

  • external command converter reads map without validation
    for backward compatibility(change done by this PR)
  • raw vehicle command converter reads map with validation
    for safety(same as before)

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…idation

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
@taikitanaka3 taikitanaka3 requested review from mkuri, TakaHoribe and a team as code owners January 21, 2023 08:12
@github-actions github-actions bot added the component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) label Jan 21, 2023
@TakaHoribe
Copy link
Contributor

@mkuri Would you check this PR?

@codecov
Copy link

codecov bot commented Jan 21, 2023

Codecov Report

Base: 11.57% // Head: 11.57% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (4a46b2f) compared to base (e94ff60).
Patch coverage: 27.77% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2711   +/-   ##
=======================================
  Coverage   11.57%   11.57%           
=======================================
  Files        1302     1302           
  Lines       90790    90790           
  Branches    23970    23971    +1     
=======================================
+ Hits        10511    10512    +1     
  Misses      69285    69285           
+ Partials    10994    10993    -1     
Flag Coverage Δ *Carryforward flag
differential 10.90% <16.66%> (?)
total 11.57% <16.66%> (-0.01%) ⬇️ Carriedforward from 8142c18

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
vehicle/raw_vehicle_cmd_converter/src/node.cpp 0.00% <0.00%> (ø)
..._converter/test/test_raw_vehicle_cmd_converter.cpp 31.57% <0.00%> (ø)
...ehicle/raw_vehicle_cmd_converter/src/brake_map.cpp 40.00% <50.00%> (ø)
...ehicle/raw_vehicle_cmd_converter/src/accel_map.cpp 37.03% <100.00%> (+3.70%) ⬆️
...ehicle/raw_vehicle_cmd_converter/src/steer_map.cpp 41.17% <100.00%> (+5.88%) ⬆️
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 85.71% <0.00%> (-2.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@mkuri mkuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taikitanaka3 taikitanaka3 merged commit 642f172 into autowarefoundation:main Jan 27, 2023
@taikitanaka3 taikitanaka3 deleted the fix/raw_vehicle_cmd_converter_validation branch January 27, 2023 05:46
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Jan 30, 2023
…idation (autowarefoundation#2711)

* fix(raw_vehicle_cmd_converter): remove external command converter validation

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>

* chore: fix

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
lexavtanke pushed a commit to lexavtanke/autoware.universe that referenced this pull request Jan 31, 2023
…idation (autowarefoundation#2711)

* fix(raw_vehicle_cmd_converter): remove external command converter validation

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>

* chore: fix

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
asana17 pushed a commit to asana17/autoware.universe that referenced this pull request Feb 8, 2023
…idation (autowarefoundation#2711)

* fix(raw_vehicle_cmd_converter): remove external command converter validation

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>

* chore: fix

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove external command converter validation
3 participants