Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ekf_localizer): use tier4_autoware_utils to simplify syntax #2708

Conversation

IshitaTakeshi
Copy link
Contributor

@IshitaTakeshi IshitaTakeshi commented Jan 20, 2023

Description

Replace ROS message creation and conversion with util functions in tier4_autoware_utils

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Jan 20, 2023
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 11.35% // Head: 11.34% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (f31e08b) compared to base (fee4d11).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2708      +/-   ##
==========================================
- Coverage   11.35%   11.34%   -0.02%     
==========================================
  Files        1279     1279              
  Lines       89462    89575     +113     
  Branches    23678    23764      +86     
==========================================
  Hits        10161    10161              
- Misses      68531    68635     +104     
- Partials    10770    10779       +9     
Flag Coverage Δ *Carryforward flag
differential 17.57% <0.00%> (?)
total 11.35% <0.00%> (ø) Carriedforward from fee4d11

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
localization/ekf_localizer/src/ekf_localizer.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IshitaTakeshi IshitaTakeshi merged commit 38992f0 into autowarefoundation:main Jan 23, 2023
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Jan 30, 2023
lexavtanke pushed a commit to lexavtanke/autoware.universe that referenced this pull request Jan 31, 2023
…utowarefoundation#2708)

Use tier4_autoware_utils to simplify syntax

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Feb 3, 2023
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Mar 23, 2023
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants