Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ekf_localizer): add a function to generate a delay time warning message #2694

Merged
merged 5 commits into from
Jan 24, 2023
Merged

refactor(ekf_localizer): add a function to generate a delay time warning message #2694

merged 5 commits into from
Jan 24, 2023

Conversation

IshitaTakeshi
Copy link
Contributor

@IshitaTakeshi IshitaTakeshi commented Jan 19, 2023 •
edited
Loading

Description

To simplify the code, I added a function to generate a delay time warning message

Related links

Tests performed

Smoke tests to check the generated message

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Jan 19, 2023
@kminoda kminoda mentioned this pull request Jan 19, 2023
Merged
7 tasks
kminoda
kminoda reviewed Jan 19, 2023
View reviewed changes
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍 I left a comment about the test

localization/ekf_localizer/CMakeLists.txt Outdated Show resolved Hide resolved
kminoda
kminoda approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IshitaTakeshi IshitaTakeshi enabled auto-merge (squash) January 24, 2023 08:46
@codecov
Copy link

codecov bot commented Jan 24, 2023 •
edited
Loading

Codecov Report

Base: 12.32% // Head: 12.32% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (2f98ca6) compared to base (4c9d247).
Patch coverage: 52.38% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2694   +/-   ##
=======================================
  Coverage   12.32%   12.32%           
=======================================
  Files        1209     1209           
  Lines       85522    85611   +89     
  Branches    24211    24285   +74     
=======================================
+ Hits        10538    10549   +11     
- Misses      63948    64011   +63     
- Partials    11036    11051   +15
Flag Coverage Δ *Carryforward flag
differential 21.53% <44.44%> (?)
total 12.32% <44.44%> (ø) Carriedforward from 4c9d247

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
localization/ekf_localizer/src/ekf_localizer.cpp 0.00% <0.00%> (ø)
...zation/ekf_localizer/test/test_warning_message.cpp 63.63% <62.50%> (-3.04%) ⬇️
localization/ekf_localizer/src/warning_message.cpp 72.72% <75.00%> (+6.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@IshitaTakeshi IshitaTakeshi merged commit 36c4b10 into autowarefoundation:main Jan 24, 2023
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jan 25, 2023
Merged
soblin pushed a commit to soblin/autoware.universe that referenced this pull request Jan 27, 2023
@IshitaTakeshi @pre-commit-ci @soblin
refactor(ekf_localizer): add a function to generate a delay time warn…
97683b1 
…ing message (autowarefoundation#2694)

* Add a function to generate a delay time warning message
* Add a warning message function for each twist and pose

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Jan 30, 2023
@IshitaTakeshi @pre-commit-ci @maxime-clem
refactor(ekf_localizer): add a function to generate a delay time warn…
1144b85 
…ing message (autowarefoundation#2694)

* Add a function to generate a delay time warning message
* Add a warning message function for each twist and pose

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
lexavtanke pushed a commit to lexavtanke/autoware.universe that referenced this pull request Jan 31, 2023
@IshitaTakeshi @pre-commit-ci @lexavtanke
refactor(ekf_localizer): add a function to generate a delay time warn…
b7a8e4f 
…ing message (autowarefoundation#2694)

* Add a function to generate a delay time warning message
* Add a warning message function for each twist and pose

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
asana17 pushed a commit to asana17/autoware.universe that referenced this pull request Feb 8, 2023
@IshitaTakeshi @pre-commit-ci @asana17
refactor(ekf_localizer): add a function to generate a delay time warn…
6773c69 
…ing message (autowarefoundation#2694)

* Add a function to generate a delay time warning message
* Add a warning message function for each twist and pose

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Mar 23, 2023
@IshitaTakeshi @pre-commit-ci @badai-nguyen
refactor(ekf_localizer): add a function to generate a delay time warn…
586c559 
…ing message (autowarefoundation#2694)

* Add a function to generate a delay time warning message
* Add a warning message function for each twist and pose

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Apr 4, 2023
@IshitaTakeshi @pre-commit-ci @badai-nguyen
refactor(ekf_localizer): add a function to generate a delay time warn…
e79b283 
…ing message (autowarefoundation#2694)

* Add a function to generate a delay time warning message
* Add a warning message function for each twist and pose

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kminoda kminoda kminoda approved these changes

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe

@YamatoAndo YamatoAndo Awaiting requested review from YamatoAndo

Assignees
No one assigned
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IshitaTakeshi @YamatoAndo @kminoda