-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: ego's position source change from tf to topic in planning/control module #2530
refactor: ego's position source change from tf to topic in planning/control module #2530
Conversation
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Codecov ReportBase: 11.54% // Head: 11.39% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2530 +/- ##
==========================================
- Coverage 11.54% 11.39% -0.15%
==========================================
Files 1307 1305 -2
Lines 91285 92513 +1228
Branches 24208 24897 +689
==========================================
+ Hits 10535 10541 +6
- Misses 69715 70877 +1162
- Partials 11035 11095 +60
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp>
…warefoundation#2561) * revert(tier4_map_launch): move config back to autoware.universe Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix map.launch.xml Signed-off-by: kminoda <koji.minoda@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
planning/behavior_path_planner/src/behavior_path_planner_node.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara |
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…ontrol module (autowarefoundation#2530) * change in pure_pursuit Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * change in motion_velocity_smoother Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * replace pose from tf to topic in behavior_path_planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * ci(pre-commit): autofix * replace PoseStamped with Pose Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * replace self_pose with self_odometry Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * delete self_pose in planner_data Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * define current_odometry Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * replace transofrmed position with topic in behavior_velocity_planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * remove current_pose Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * ci(pre-commit): autofix * fix build error Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * ci(pre-commit): autofix * fix(system_monitor): change default param path (autowarefoundation#2560) Signed-off-by: kminoda <koji.minoda@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp> * revert(tier4_map_launch): move config back to autoware.universe (autowarefoundation#2561) * revert(tier4_map_launch): move config back to autoware.universe Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix map.launch.xml Signed-off-by: kminoda <koji.minoda@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp> * define self_odometry as ConstPointer Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * tf to topic in obstacle avoidance planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * tf to topic in obstacle velocity limiter node Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * tf to topic in obstacle velocity limiter node Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix build error Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * ci(pre-commit): autofix * replace TF to odom Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * delete unnecessary unlock Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix builf error * fix bug Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * self_pose to self_odometry in lanechange module Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix small bug Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * Update node.cpp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
…ontrol module (autowarefoundation#2530) * change in pure_pursuit Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * change in motion_velocity_smoother Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * replace pose from tf to topic in behavior_path_planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * ci(pre-commit): autofix * replace PoseStamped with Pose Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * replace self_pose with self_odometry Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * delete self_pose in planner_data Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * define current_odometry Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * replace transofrmed position with topic in behavior_velocity_planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * remove current_pose Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * ci(pre-commit): autofix * fix build error Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * ci(pre-commit): autofix * fix(system_monitor): change default param path (autowarefoundation#2560) Signed-off-by: kminoda <koji.minoda@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp> * revert(tier4_map_launch): move config back to autoware.universe (autowarefoundation#2561) * revert(tier4_map_launch): move config back to autoware.universe Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix map.launch.xml Signed-off-by: kminoda <koji.minoda@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp> * define self_odometry as ConstPointer Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * tf to topic in obstacle avoidance planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * tf to topic in obstacle velocity limiter node Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * tf to topic in obstacle velocity limiter node Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix build error Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * ci(pre-commit): autofix * replace TF to odom Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * delete unnecessary unlock Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix builf error * fix bug Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * self_pose to self_odometry in lanechange module Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix small bug Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * Update node.cpp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
…ontrol module (autowarefoundation#2530) * change in pure_pursuit Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * change in motion_velocity_smoother Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * replace pose from tf to topic in behavior_path_planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * ci(pre-commit): autofix * replace PoseStamped with Pose Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * replace self_pose with self_odometry Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * delete self_pose in planner_data Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * define current_odometry Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * replace transofrmed position with topic in behavior_velocity_planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * remove current_pose Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * ci(pre-commit): autofix * fix build error Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * ci(pre-commit): autofix * fix(system_monitor): change default param path (autowarefoundation#2560) Signed-off-by: kminoda <koji.minoda@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp> * revert(tier4_map_launch): move config back to autoware.universe (autowarefoundation#2561) * revert(tier4_map_launch): move config back to autoware.universe Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix map.launch.xml Signed-off-by: kminoda <koji.minoda@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp> * define self_odometry as ConstPointer Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * tf to topic in obstacle avoidance planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * tf to topic in obstacle velocity limiter node Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * tf to topic in obstacle velocity limiter node Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix build error Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * ci(pre-commit): autofix * replace TF to odom Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * delete unnecessary unlock Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix builf error * fix bug Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * self_pose to self_odometry in lanechange module Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix small bug Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * Update node.cpp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
…ontrol module (autowarefoundation#2530) * change in pure_pursuit Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * change in motion_velocity_smoother Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * replace pose from tf to topic in behavior_path_planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * ci(pre-commit): autofix * replace PoseStamped with Pose Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * replace self_pose with self_odometry Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * delete self_pose in planner_data Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * define current_odometry Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * replace transofrmed position with topic in behavior_velocity_planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * remove current_pose Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * ci(pre-commit): autofix * fix build error Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * ci(pre-commit): autofix * fix(system_monitor): change default param path (autowarefoundation#2560) Signed-off-by: kminoda <koji.minoda@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp> * revert(tier4_map_launch): move config back to autoware.universe (autowarefoundation#2561) * revert(tier4_map_launch): move config back to autoware.universe Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix map.launch.xml Signed-off-by: kminoda <koji.minoda@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp> * define self_odometry as ConstPointer Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * tf to topic in obstacle avoidance planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * tf to topic in obstacle velocity limiter node Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * tf to topic in obstacle velocity limiter node Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix build error Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * ci(pre-commit): autofix * replace TF to odom Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * delete unnecessary unlock Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix builf error * fix bug Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * self_pose to self_odometry in lanechange module Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix small bug Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * Update node.cpp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Description
Relates to #1784
Since using getTransform() to obtain the self-position would cause a timeout, the ego-position was replaced with an odometry message that is subscribed in each module.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.
In-review checklist for the PR reviewers
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.