Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ego's position source change from tf to topic in planning/control module #2530

Merged

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Dec 20, 2022

Description

Relates to #1784

Since using getTransform() to obtain the self-position would cause a timeout, the ego-position was replaced with an odometry message that is subscribed in each module.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
    After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@github-actions github-actions bot added component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Dec 20, 2022
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 11.54% // Head: 11.39% // Decreases project coverage by -0.15% ⚠️

Coverage data is based on head (1e192a4) compared to base (11ce12b).
Patch coverage: 5.04% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2530      +/-   ##
==========================================
- Coverage   11.54%   11.39%   -0.15%     
==========================================
  Files        1307     1305       -2     
  Lines       91285    92513    +1228     
  Branches    24208    24897     +689     
==========================================
+ Hits        10535    10541       +6     
- Misses      69715    70877    +1162     
- Partials    11035    11095      +60     
Flag Coverage Δ *Carryforward flag
differential 6.19% <2.08%> (?)
total 11.52% <3.93%> (-0.03%) ⬇️ Carriedforward from dddff0e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...c/pure_pursuit/pure_pursuit_lateral_controller.cpp 0.00% <0.00%> (ø)
localization/ekf_localizer/src/ekf_localizer.cpp 0.00% <0.00%> (ø)
...havior_path_planner/behavior_path_planner_node.hpp 0.00% <0.00%> (ø)
...ner/include/behavior_path_planner/data_manager.hpp 0.00% <ø> (ø)
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <0.00%> (ø)
...th_planner/scene_module/scene_module_interface.hpp 0.00% <0.00%> (ø)
...nner/scene_module/side_shift/side_shift_module.hpp 0.00% <0.00%> (ø)
.../scene_module/utils/geometric_parallel_parking.hpp 0.00% <ø> (ø)
...lanner/include/behavior_path_planner/utilities.hpp 34.48% <ø> (+5.07%) ⬆️
...or_path_planner/src/behavior_path_planner_node.cpp 0.27% <0.00%> (+0.11%) ⬆️
... and 77 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kyoichi-sugahara kyoichi-sugahara changed the title Refactor/tf to topic refactor: egoposition sorce change from tf to topic in planning/control module Dec 21, 2022
@kyoichi-sugahara kyoichi-sugahara changed the title refactor: egoposition sorce change from tf to topic in planning/control module refactor: ego's position sorce change from tf to topic in planning/control module Dec 21, 2022
kyoichi-sugahara and others added 15 commits December 21, 2022 09:17
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>
…warefoundation#2561)

* revert(tier4_map_launch): move config back to autoware.universe

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* fix map.launch.xml

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@github-actions github-actions bot added component:launch Launch files, scripts and initialization tools. (auto-assigned) component:system System design and integration. (auto-assigned) labels Dec 27, 2022
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@TakaHoribe TakaHoribe self-requested a review January 11, 2023 02:48
@TomohitoAndo
Copy link
Contributor

@kyoichi-sugahara
typo in PR title?
sorce -> source

@kyoichi-sugahara kyoichi-sugahara changed the title refactor: ego's position sorce change from tf to topic in planning/control module refactor: ego's position source change from tf to topic in planning/control module Jan 12, 2023
@TakaHoribe TakaHoribe merged commit 60d76c1 into autowarefoundation:main Jan 24, 2023
veqcc pushed a commit to veqcc/autoware.universe that referenced this pull request Jan 25, 2023
…ontrol module (autowarefoundation#2530)

* change in pure_pursuit

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* change in motion_velocity_smoother

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* replace pose from tf to topic in behavior_path_planner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* ci(pre-commit): autofix

* replace PoseStamped with Pose

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* replace self_pose with self_odometry

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* delete self_pose in planner_data

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* define current_odometry

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* replace transofrmed position with topic in behavior_velocity_planner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* remove current_pose

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* ci(pre-commit): autofix

* fix build error

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* ci(pre-commit): autofix

* fix(system_monitor): change default param path (autowarefoundation#2560)

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* revert(tier4_map_launch): move config back to autoware.universe (autowarefoundation#2561)

* revert(tier4_map_launch): move config back to autoware.universe

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* fix map.launch.xml

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* define self_odometry as ConstPointer

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* tf to topic in obstacle avoidance planner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* tf to topic in obstacle velocity limiter node

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* tf to topic in obstacle velocity limiter node

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix build error

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* ci(pre-commit): autofix

* replace TF to odom

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* delete unnecessary unlock

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix builf error

* fix bug

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* self_pose to self_odometry in lanechange module

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix small bug

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* Update node.cpp

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Jan 30, 2023
…ontrol module (autowarefoundation#2530)

* change in pure_pursuit

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* change in motion_velocity_smoother

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* replace pose from tf to topic in behavior_path_planner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* ci(pre-commit): autofix

* replace PoseStamped with Pose

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* replace self_pose with self_odometry

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* delete self_pose in planner_data

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* define current_odometry

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* replace transofrmed position with topic in behavior_velocity_planner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* remove current_pose

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* ci(pre-commit): autofix

* fix build error

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* ci(pre-commit): autofix

* fix(system_monitor): change default param path (autowarefoundation#2560)

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* revert(tier4_map_launch): move config back to autoware.universe (autowarefoundation#2561)

* revert(tier4_map_launch): move config back to autoware.universe

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* fix map.launch.xml

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* define self_odometry as ConstPointer

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* tf to topic in obstacle avoidance planner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* tf to topic in obstacle velocity limiter node

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* tf to topic in obstacle velocity limiter node

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix build error

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* ci(pre-commit): autofix

* replace TF to odom

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* delete unnecessary unlock

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix builf error

* fix bug

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* self_pose to self_odometry in lanechange module

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix small bug

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* Update node.cpp

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
lexavtanke pushed a commit to lexavtanke/autoware.universe that referenced this pull request Jan 31, 2023
…ontrol module (autowarefoundation#2530)

* change in pure_pursuit

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* change in motion_velocity_smoother

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* replace pose from tf to topic in behavior_path_planner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* ci(pre-commit): autofix

* replace PoseStamped with Pose

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* replace self_pose with self_odometry

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* delete self_pose in planner_data

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* define current_odometry

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* replace transofrmed position with topic in behavior_velocity_planner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* remove current_pose

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* ci(pre-commit): autofix

* fix build error

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* ci(pre-commit): autofix

* fix(system_monitor): change default param path (autowarefoundation#2560)

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* revert(tier4_map_launch): move config back to autoware.universe (autowarefoundation#2561)

* revert(tier4_map_launch): move config back to autoware.universe

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* fix map.launch.xml

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* define self_odometry as ConstPointer

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* tf to topic in obstacle avoidance planner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* tf to topic in obstacle velocity limiter node

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* tf to topic in obstacle velocity limiter node

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix build error

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* ci(pre-commit): autofix

* replace TF to odom

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* delete unnecessary unlock

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix builf error

* fix bug

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* self_pose to self_odometry in lanechange module

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix small bug

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* Update node.cpp

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
asana17 pushed a commit to asana17/autoware.universe that referenced this pull request Feb 8, 2023
…ontrol module (autowarefoundation#2530)

* change in pure_pursuit

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* change in motion_velocity_smoother

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* replace pose from tf to topic in behavior_path_planner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* ci(pre-commit): autofix

* replace PoseStamped with Pose

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* replace self_pose with self_odometry

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* delete self_pose in planner_data

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* define current_odometry

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* replace transofrmed position with topic in behavior_velocity_planner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* remove current_pose

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* ci(pre-commit): autofix

* fix build error

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* ci(pre-commit): autofix

* fix(system_monitor): change default param path (autowarefoundation#2560)

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* revert(tier4_map_launch): move config back to autoware.universe (autowarefoundation#2561)

* revert(tier4_map_launch): move config back to autoware.universe

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* fix map.launch.xml

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* define self_odometry as ConstPointer

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* tf to topic in obstacle avoidance planner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* tf to topic in obstacle velocity limiter node

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* tf to topic in obstacle velocity limiter node

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix build error

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* ci(pre-commit): autofix

* replace TF to odom

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* delete unnecessary unlock

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix builf error

* fix bug

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* self_pose to self_odometry in lanechange module

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix small bug

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* Update node.cpp

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
@kyoichi-sugahara kyoichi-sugahara deleted the refactor/TF_to_topic branch April 15, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants