Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_perception_launch): change the merge priority of roi_cluster_fusion to the lowest #2522

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

yukke42
Copy link
Contributor

@yukke42 yukke42 commented Dec 19, 2022

Signed-off-by: yukke42 yusuke.muramatsu@tier4.jp

Description

There are some objects which shape is estimated incorrectly by the roi_cluster_fusion pipeline, but this is the limitation of the algorithm becase of the lack of information, s.t. the orientation of objects. Therefore, the merge priority of roi_cluster_fusion changes to the lowest.

The screenshots below show the false detection from roi_cluster_fusion.
green: centerpoint
pink: roi_cluster_fusion

Screenshot from 2022-12-22 11-40-40

Screenshot from 2022-12-22 11-44-12

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Dec 19, 2022
…er_fusion to the lowest

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
@yukke42 yukke42 force-pushed the change-merger-priority branch from 590b403 to 740f5ac Compare December 22, 2022 03:03
@yukke42 yukke42 changed the title feat(tier4_perception_launch): change object merge priority of camera-lidar-fusion feat(tier4_perception_launch): change the merge priority of roi_cluster_fusion to the lowest Dec 22, 2022
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 10.55% // Head: 10.57% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (590b403) compared to base (8bdfe7c).
Patch has no changes to coverable lines.

❗ Current head 590b403 differs from pull request most recent head 89e1730. Consider uploading reports for the commit 89e1730 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2522      +/-   ##
==========================================
+ Coverage   10.55%   10.57%   +0.01%     
==========================================
  Files        1268     1265       -3     
  Lines       87604    87439     -165     
  Branches    20931    20942      +11     
==========================================
- Hits         9246     9244       -2     
+ Misses      68495    68333     -162     
+ Partials     9863     9862       -1     
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total 10.57% <ø> (+0.01%) ⬆️ Carriedforward from c7d3b7d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...planning_evaluator/src/planning_evaluator_node.cpp 34.37% <0.00%> (-2.09%) ⬇️
planning/behavior_path_planner/src/utilities.cpp 3.68% <0.00%> (-0.04%) ⬇️
...or_path_planner/src/behavior_path_planner_node.cpp 0.18% <0.00%> (-0.01%) ⬇️
planning/obstacle_cruise_planner/src/node.cpp 0.00% <0.00%> (ø)
planning/obstacle_cruise_planner/src/utils.cpp 0.00% <0.00%> (ø)
planning/static_centerline_optimizer/src/utils.cpp 0.00% <0.00%> (ø)
...erception/traffic_light_classifier/src/nodelet.cpp 0.00% <0.00%> (ø)
...nning/behavior_path_planner/src/path_utilities.cpp 0.00% <0.00%> (ø)
...tem/system_monitor/src/net_monitor/net_monitor.cpp 0.00% <0.00%> (ø)
...eption/map_based_prediction/src/path_generator.cpp 0.00% <0.00%> (ø)
... and 39 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukke42 yukke42 enabled auto-merge (squash) December 22, 2022 06:52
@yukke42 yukke42 merged commit 7ef0709 into autowarefoundation:main Dec 22, 2022
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…er_fusion to the lowest (autowarefoundation#2522)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants