-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_perception_launch): change the merge priority of roi_cluster_fusion to the lowest #2522
feat(tier4_perception_launch): change the merge priority of roi_cluster_fusion to the lowest #2522
Conversation
…er_fusion to the lowest Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
590b403
to
740f5ac
Compare
Codecov ReportBase: 10.55% // Head: 10.57% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2522 +/- ##
==========================================
+ Coverage 10.55% 10.57% +0.01%
==========================================
Files 1268 1265 -3
Lines 87604 87439 -165
Branches 20931 20942 +11
==========================================
- Hits 9246 9244 -2
+ Misses 68495 68333 -162
+ Partials 9863 9862 -1
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…er_fusion to the lowest (autowarefoundation#2522) Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: yukke42 yusuke.muramatsu@tier4.jp
Description
There are some objects which shape is estimated incorrectly by the roi_cluster_fusion pipeline, but this is the limitation of the algorithm becase of the lack of information, s.t. the orientation of objects. Therefore, the merge priority of roi_cluster_fusion changes to the lowest.
The screenshots below show the false detection from roi_cluster_fusion.
green: centerpoint
pink: roi_cluster_fusion
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.