fix(behavior_velocity): deadlock condition #240

taikitanaka3 · 2022-01-11T02:33:24Z

Related Issue(required)

tier4/AutowareArchitectureProposal.iv#746

Description(required)

consider dead lock condition for behavior velocity
the condition when this happened : ego vehicle surpass stop line without stopping velocity within certain distance to stop line.

case where stop line lasts forever until it goes back(drive backward) to stop line

This PR
fix: dead lock condition which autoware doesn't assumed.
not fix: need to consider distance to stop line using arc length with corresponding lane id.

Review Procedure(required)

launch Psim

use rqt_publisher to manually override ego vehicle and see if walkway that ego vehicle passed is expired after stop
https://user-images.githubusercontent.com/65527974/143822890-b4ea74a5-cd57-41ce-8b34-6cfa798daeb5.mp4

see normal behavior is the same as before(stop line and walkway).
https://user-images.githubusercontent.com/65527974/143827037-5349a87b-1008-44a8-b651-ca71b27d131f.mp4

Related PR(optional)

tier4/AutowareArchitectureProposal.iv#746

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Read commit-guidelines
Assign PR to reviewer

If you are adding new package following items are required:

Documentation with description of the package is available
A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

Commits are properly organized and messages are according to the guideline
PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

All open points are addressed and tracked via issues or tickets

CI Checks

Build and test for PR / build-and-test-pr: Required to pass before the merge.
Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

taikitanaka3 · 2022-01-11T03:26:57Z

~~TODO autoware_utils -> tier4_autoware_utils~~ -> Done

* release v0.4.0 * Modify to use projection matrix with undistorted 2D result (autowarefoundation#722) Signed-off-by: Akihito Ohasto <aohsato@gmail.com> * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "remove ROS1 packages temporarily" This reverts commit 6e1593f7d630fc1e670df40fe1723890fc238f17. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Rename launch files to launch.xml (autowarefoundation#28) * Rename h files to hpp (autowarefoundation#142) * Change includes * Rename files * Adjustments to make things compile * Other packages * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * ported roi_cluster_fusion from ROS1 to ROS2 (autowarefoundation#118) compiles succesfully. Getting some undefined reference error while launching the node. * Port euclidean cluster (autowarefoundation#120) * porting CmakeLists.txt and package.xml in progress * ported CMakeLists.txt and package.xml to ROS2 * Ported euclidean_cluster from ROS1 to ROS2 * deleted unnecesary files * fixed transient_local Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * hotfix roi_cluster_fusion (autowarefoundation#239) * Fix perception launches (autowarefoundation#240) * fix roi_cluster_fusion launch Signed-off-by: Takamasa Horibe <takamasa.horib@gmail.com> * add comment on launch Signed-off-by: Takamasa Horibe <takamasa.horib@gmail.com> Co-authored-by: Takamasa Horibe <takamasa.horib@gmail.com> * Ros2 v0.8.0 roi cluster fusion (autowarefoundation#321) * restore v0.5.0 * Feature/fusion debug (autowarefoundation#1051) * add debuger * change param * add publisher * Compatible with opencv4 (autowarefoundation#1156) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * refactor for ros2 style * fix code * to hpp * fix code * uncursify Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * [roi_cluster_fusion]: Avoid redeclaring parameter for compressed image publisher (autowarefoundation#346) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix transform (autowarefoundation#420) * Replace rclcpp::Time(0) by tf2::TimePointZero() in lookupTransform Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix canTransform Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix test Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix typo in perception module (autowarefoundation#440) * add use_sim-time option (autowarefoundation#454) * Format launch files (autowarefoundation#1219) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Unify Apache-2.0 license name (autowarefoundation#1242) * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add pre-commit (autowarefoundation#1560) * add pre-commit * add pre-commit-config * add additional settings for private repository * use default pre-commit-config * update pre-commit setting * Ignore whitespace for line breaks in markdown * Update .github/workflows/pre-commit.yml Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * exclude svg * remove pretty-format-json * add double-quote-string-fixer * consider COLCON_IGNORE file when seaching modified package * format file * pre-commit fixes * Update pre-commit.yml * Update .pre-commit-config.yaml Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: pre-commit <pre-commit@example.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * [roi_cluster_fusion]: Fix poting mistake (autowarefoundation#1624) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix typo & check debugger (autowarefoundation#1511) (autowarefoundation#1625) Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com> * Use set_remap for if tag (autowarefoundation#1800) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Apply format (autowarefoundation#1999) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Fix cpplint Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Detection by tracker (autowarefoundation#1910) * initial commit * backup * apply format * cosmetic change * implement divided under segmenterd clusters * cosmetic change * bug fix * bug fix * bug fix * modify launch * add debug and bug fix * bug fix * bug fix * add no found tracked object * modify parameters and cmake * bug fix * remove debug info * add readme * modify clustering launch * run pre-commit * cosmetic change * cosmetic change * cosmetic change * apply markdownlint * modify launch * modify for cpplint * modify qos * change int to size_T * bug fix * change perception qos * Update perception/object_recognition/detection/detection_by_tracker/package.xml Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * cosmetic change * cosmetic change * fix launch * Update perception/object_recognition/detection/detection_by_tracker/src/utils.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * modify header include order * change include order * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * change to std::optional * cosmetic change * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * bug fix * modify readme Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * sync rc rc/v0.23.0 (autowarefoundation#2219) * Fix qos in roi cluster fusion (autowarefoundation#2218) * fix confidence (autowarefoundation#2220) Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * port roi cluster fusion (autowarefoundation#536) * remove COLCON_IGNORE * use DetectedObjectsWithFeature * fix topic type * update overwrite condition * add README of roi_cluster_fusion (autowarefoundation#653) * add README of roi_cluster_fusion * fix typo Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * add image Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Akihito Ohsato <aohsato@gmail.com> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: nik-tier4 <71747268+nik-tier4@users.noreply.github.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takamasa Horibe <takamasa.horib@gmail.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: pre-commit <pre-commit@example.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>

* release v0.4.0 * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "remove ROS1 packages temporarily" This reverts commit d6a59ac4c3762cb58ce6ca3e2cb31b3b8fc810ea. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Rename launch files to launch.xml (autowarefoundation#28) * Rename h files to hpp (autowarefoundation#142) * Change includes * Rename files * Adjustments to make things compile * Other packages * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * Port euclidean cluster (autowarefoundation#120) * porting CmakeLists.txt and package.xml in progress * ported CMakeLists.txt and package.xml to ROS2 * Ported euclidean_cluster from ROS1 to ROS2 * deleted unnecesary files * fixed transient_local Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Fix perception launches (autowarefoundation#240) * fix roi_cluster_fusion launch Signed-off-by: Takamasa Horibe <takamasa.horib@gmail.com> * add comment on launch Signed-off-by: Takamasa Horibe <takamasa.horib@gmail.com> Co-authored-by: Takamasa Horibe <takamasa.horib@gmail.com> * Ros2 v0.8.0 euclidean cluster (autowarefoundation#310) * restore euclidean cluster files for v0.8.0 update * fix typos in perception (autowarefoundation#862) * Feature/camera lidar perception (autowarefoundation#937) * add object splitter Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * add object merger Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * change pkg name Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * cosmetic change Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * add comment Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * remove litter Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * bug fix : debug code Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * enable vehicle to unknown track Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * bug fix * add object position in clustering * 🚮 * change param * fix name * bug fix * add install * Feature/fusion debug (autowarefoundation#1051) * add debuger * change param * add publisher * Revert "restore euclidean cluster files for v0.8.0 update" This reverts commit 894cb8746622b4eb88f2cf1b036cc8c94ab1ac96. * fix bug * use containter to launch nodelet * add line * [euclidean_cluster]: Fix launch python and CMakeLists.txt Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * add use_sim-time option (autowarefoundation#454) * Format launch files (autowarefoundation#1219) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Unify Apache-2.0 license name (autowarefoundation#1242) * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix lint errors (autowarefoundation#1378) * Fix lint errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix variable names Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Porting euclidean cluster (autowarefoundation#1291) * create config for euclidean cluster (autowarefoundation#1206) * create config * fix EOF * fix cmake list (autowarefoundation#1208) * Add load_composable_node_param Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Use tier4 voxel grid filter Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Refactor voxel grid based euclidean cluster launch Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix launch xml tag Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add missing arguments Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix pointcloud subscriber qos Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix dependency in CMakeLists.txt Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * Invoke code formatter at pre-commit (autowarefoundation#1935) * Run ament_uncrustify at pre-commit * Reformat existing files * Fix copyright and cpplint errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * Feature/clustering lib (autowarefoundation#1914) * change to lib for detection by tracking * refactor * apply format * Detection by tracker (autowarefoundation#1910) * initial commit * backup * apply format * cosmetic change * implement divided under segmenterd clusters * cosmetic change * bug fix * bug fix * bug fix * modify launch * add debug and bug fix * bug fix * bug fix * add no found tracked object * modify parameters and cmake * bug fix * remove debug info * add readme * modify clustering launch * run pre-commit * cosmetic change * cosmetic change * cosmetic change * apply markdownlint * modify launch * modify for cpplint * modify qos * change int to size_T * bug fix * change perception qos * Update perception/object_recognition/detection/detection_by_tracker/package.xml Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * cosmetic change * cosmetic change * fix launch * Update perception/object_recognition/detection/detection_by_tracker/src/utils.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * modify header include order * change include order * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * change to std::optional * cosmetic change * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * bug fix * modify readme Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * port euclidean_cluster (autowarefoundation#533) * delete COLCON_IGNORE * change dynamic_object_with_feature_array to detected_objects_with_feature * add classification * add classification.probability * add README of euclidean_cluster (autowarefoundation#614) * add README of euclidean_cluster * add period Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * update README Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * auto fix no ground pointcloud topic name (autowarefoundation#704) * fix/rename segmentation namespace (autowarefoundation#742) * rename segmentation directory * fix namespace: system stack * fix namespace: planning * fix namespace: control stack * fix namespace: perception stack * fix readme Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: nik-tier4 <71747268+nik-tier4@users.noreply.github.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takamasa Horibe <takamasa.horib@gmail.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Takeshi Ishita <ishitah.takeshi@gmail.com> Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

planning/behavior_velocity_planner/src/scene_module/crosswalk/scene_walkway.cpp

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

taikitanaka3 · 2022-01-25T07:12:43Z

release-note

tkimura4

LGTM

* release v0.4.0 * Modify to use projection matrix with undistorted 2D result (autowarefoundation#722) Signed-off-by: Akihito Ohasto <aohsato@gmail.com> * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "remove ROS1 packages temporarily" This reverts commit 6e1593f7d630fc1e670df40fe1723890fc238f17. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Rename launch files to launch.xml (autowarefoundation#28) * Rename h files to hpp (autowarefoundation#142) * Change includes * Rename files * Adjustments to make things compile * Other packages * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * ported roi_cluster_fusion from ROS1 to ROS2 (autowarefoundation#118) compiles succesfully. Getting some undefined reference error while launching the node. * Port euclidean cluster (autowarefoundation#120) * porting CmakeLists.txt and package.xml in progress * ported CMakeLists.txt and package.xml to ROS2 * Ported euclidean_cluster from ROS1 to ROS2 * deleted unnecesary files * fixed transient_local Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * hotfix roi_cluster_fusion (autowarefoundation#239) * Fix perception launches (autowarefoundation#240) * fix roi_cluster_fusion launch Signed-off-by: Takamasa Horibe <takamasa.horib@gmail.com> * add comment on launch Signed-off-by: Takamasa Horibe <takamasa.horib@gmail.com> Co-authored-by: Takamasa Horibe <takamasa.horib@gmail.com> * Ros2 v0.8.0 roi cluster fusion (autowarefoundation#321) * restore v0.5.0 * Feature/fusion debug (autowarefoundation#1051) * add debuger * change param * add publisher * Compatible with opencv4 (autowarefoundation#1156) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * refactor for ros2 style * fix code * to hpp * fix code * uncursify Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * [roi_cluster_fusion]: Avoid redeclaring parameter for compressed image publisher (autowarefoundation#346) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix transform (autowarefoundation#420) * Replace rclcpp::Time(0) by tf2::TimePointZero() in lookupTransform Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix canTransform Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix test Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix typo in perception module (autowarefoundation#440) * add use_sim-time option (autowarefoundation#454) * Format launch files (autowarefoundation#1219) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Unify Apache-2.0 license name (autowarefoundation#1242) * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add pre-commit (autowarefoundation#1560) * add pre-commit * add pre-commit-config * add additional settings for private repository * use default pre-commit-config * update pre-commit setting * Ignore whitespace for line breaks in markdown * Update .github/workflows/pre-commit.yml Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * exclude svg * remove pretty-format-json * add double-quote-string-fixer * consider COLCON_IGNORE file when seaching modified package * format file * pre-commit fixes * Update pre-commit.yml * Update .pre-commit-config.yaml Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: pre-commit <pre-commit@example.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * [roi_cluster_fusion]: Fix poting mistake (autowarefoundation#1624) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix typo & check debugger (autowarefoundation#1511) (autowarefoundation#1625) Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com> * Use set_remap for if tag (autowarefoundation#1800) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Apply format (autowarefoundation#1999) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Fix cpplint Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Detection by tracker (autowarefoundation#1910) * initial commit * backup * apply format * cosmetic change * implement divided under segmenterd clusters * cosmetic change * bug fix * bug fix * bug fix * modify launch * add debug and bug fix * bug fix * bug fix * add no found tracked object * modify parameters and cmake * bug fix * remove debug info * add readme * modify clustering launch * run pre-commit * cosmetic change * cosmetic change * cosmetic change * apply markdownlint * modify launch * modify for cpplint * modify qos * change int to size_T * bug fix * change perception qos * Update perception/object_recognition/detection/detection_by_tracker/package.xml Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * cosmetic change * cosmetic change * fix launch * Update perception/object_recognition/detection/detection_by_tracker/src/utils.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * modify header include order * change include order * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * change to std::optional * cosmetic change * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * bug fix * modify readme Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * sync rc rc/v0.23.0 (autowarefoundation#2219) * Fix qos in roi cluster fusion (autowarefoundation#2218) * fix confidence (autowarefoundation#2220) Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * port roi cluster fusion (autowarefoundation#536) * remove COLCON_IGNORE * use DetectedObjectsWithFeature * fix topic type * update overwrite condition * add README of roi_cluster_fusion (autowarefoundation#653) * add README of roi_cluster_fusion * fix typo Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * add image Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Akihito Ohsato <aohsato@gmail.com> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: nik-tier4 <71747268+nik-tier4@users.noreply.github.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takamasa Horibe <takamasa.horib@gmail.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: pre-commit <pre-commit@example.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>

* release v0.4.0 * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "remove ROS1 packages temporarily" This reverts commit d6a59ac4c3762cb58ce6ca3e2cb31b3b8fc810ea. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Rename launch files to launch.xml (autowarefoundation#28) * Rename h files to hpp (autowarefoundation#142) * Change includes * Rename files * Adjustments to make things compile * Other packages * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * Port euclidean cluster (autowarefoundation#120) * porting CmakeLists.txt and package.xml in progress * ported CMakeLists.txt and package.xml to ROS2 * Ported euclidean_cluster from ROS1 to ROS2 * deleted unnecesary files * fixed transient_local Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Fix perception launches (autowarefoundation#240) * fix roi_cluster_fusion launch Signed-off-by: Takamasa Horibe <takamasa.horib@gmail.com> * add comment on launch Signed-off-by: Takamasa Horibe <takamasa.horib@gmail.com> Co-authored-by: Takamasa Horibe <takamasa.horib@gmail.com> * Ros2 v0.8.0 euclidean cluster (autowarefoundation#310) * restore euclidean cluster files for v0.8.0 update * fix typos in perception (autowarefoundation#862) * Feature/camera lidar perception (autowarefoundation#937) * add object splitter Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * add object merger Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * change pkg name Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * cosmetic change Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * add comment Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * remove litter Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * bug fix : debug code Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * enable vehicle to unknown track Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * bug fix * add object position in clustering * 🚮 * change param * fix name * bug fix * add install * Feature/fusion debug (autowarefoundation#1051) * add debuger * change param * add publisher * Revert "restore euclidean cluster files for v0.8.0 update" This reverts commit 894cb8746622b4eb88f2cf1b036cc8c94ab1ac96. * fix bug * use containter to launch nodelet * add line * [euclidean_cluster]: Fix launch python and CMakeLists.txt Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * add use_sim-time option (autowarefoundation#454) * Format launch files (autowarefoundation#1219) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Unify Apache-2.0 license name (autowarefoundation#1242) * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix lint errors (autowarefoundation#1378) * Fix lint errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix variable names Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Porting euclidean cluster (autowarefoundation#1291) * create config for euclidean cluster (autowarefoundation#1206) * create config * fix EOF * fix cmake list (autowarefoundation#1208) * Add load_composable_node_param Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Use tier4 voxel grid filter Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Refactor voxel grid based euclidean cluster launch Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix launch xml tag Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add missing arguments Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix pointcloud subscriber qos Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix dependency in CMakeLists.txt Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * Invoke code formatter at pre-commit (autowarefoundation#1935) * Run ament_uncrustify at pre-commit * Reformat existing files * Fix copyright and cpplint errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * Feature/clustering lib (autowarefoundation#1914) * change to lib for detection by tracking * refactor * apply format * Detection by tracker (autowarefoundation#1910) * initial commit * backup * apply format * cosmetic change * implement divided under segmenterd clusters * cosmetic change * bug fix * bug fix * bug fix * modify launch * add debug and bug fix * bug fix * bug fix * add no found tracked object * modify parameters and cmake * bug fix * remove debug info * add readme * modify clustering launch * run pre-commit * cosmetic change * cosmetic change * cosmetic change * apply markdownlint * modify launch * modify for cpplint * modify qos * change int to size_T * bug fix * change perception qos * Update perception/object_recognition/detection/detection_by_tracker/package.xml Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * cosmetic change * cosmetic change * fix launch * Update perception/object_recognition/detection/detection_by_tracker/src/utils.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * modify header include order * change include order * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * change to std::optional * cosmetic change * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * bug fix * modify readme Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * port euclidean_cluster (autowarefoundation#533) * delete COLCON_IGNORE * change dynamic_object_with_feature_array to detected_objects_with_feature * add classification * add classification.probability * add README of euclidean_cluster (autowarefoundation#614) * add README of euclidean_cluster * add period Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * update README Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * auto fix no ground pointcloud topic name (autowarefoundation#704) * fix/rename segmentation namespace (autowarefoundation#742) * rename segmentation directory * fix namespace: system stack * fix namespace: planning * fix namespace: control stack * fix namespace: perception stack * fix readme Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: nik-tier4 <71747268+nik-tier4@users.noreply.github.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takamasa Horibe <takamasa.horib@gmail.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Takeshi Ishita <ishitah.takeshi@gmail.com> Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>

* fix(behavior_velocity): fix dead lock condition Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore(behavior_velocity): unite valiable name to stop line Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix(behavior_velocity): fix dead lock condition of merge from private Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* release v0.4.0 * Modify to use projection matrix with undistorted 2D result (autowarefoundation#722) Signed-off-by: Akihito Ohasto <aohsato@gmail.com> * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "remove ROS1 packages temporarily" This reverts commit 6e1593f7d630fc1e670df40fe1723890fc238f17. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Rename launch files to launch.xml (autowarefoundation#28) * Rename h files to hpp (autowarefoundation#142) * Change includes * Rename files * Adjustments to make things compile * Other packages * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * ported roi_cluster_fusion from ROS1 to ROS2 (autowarefoundation#118) compiles succesfully. Getting some undefined reference error while launching the node. * Port euclidean cluster (autowarefoundation#120) * porting CmakeLists.txt and package.xml in progress * ported CMakeLists.txt and package.xml to ROS2 * Ported euclidean_cluster from ROS1 to ROS2 * deleted unnecesary files * fixed transient_local Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * hotfix roi_cluster_fusion (autowarefoundation#239) * Fix perception launches (autowarefoundation#240) * fix roi_cluster_fusion launch Signed-off-by: Takamasa Horibe <takamasa.horib@gmail.com> * add comment on launch Signed-off-by: Takamasa Horibe <takamasa.horib@gmail.com> Co-authored-by: Takamasa Horibe <takamasa.horib@gmail.com> * Ros2 v0.8.0 roi cluster fusion (autowarefoundation#321) * restore v0.5.0 * Feature/fusion debug (autowarefoundation#1051) * add debuger * change param * add publisher * Compatible with opencv4 (autowarefoundation#1156) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * refactor for ros2 style * fix code * to hpp * fix code * uncursify Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * [roi_cluster_fusion]: Avoid redeclaring parameter for compressed image publisher (autowarefoundation#346) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix transform (autowarefoundation#420) * Replace rclcpp::Time(0) by tf2::TimePointZero() in lookupTransform Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix canTransform Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix test Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix typo in perception module (autowarefoundation#440) * add use_sim-time option (autowarefoundation#454) * Format launch files (autowarefoundation#1219) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Unify Apache-2.0 license name (autowarefoundation#1242) * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add pre-commit (autowarefoundation#1560) * add pre-commit * add pre-commit-config * add additional settings for private repository * use default pre-commit-config * update pre-commit setting * Ignore whitespace for line breaks in markdown * Update .github/workflows/pre-commit.yml Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * exclude svg * remove pretty-format-json * add double-quote-string-fixer * consider COLCON_IGNORE file when seaching modified package * format file * pre-commit fixes * Update pre-commit.yml * Update .pre-commit-config.yaml Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: pre-commit <pre-commit@example.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * [roi_cluster_fusion]: Fix poting mistake (autowarefoundation#1624) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix typo & check debugger (autowarefoundation#1511) (autowarefoundation#1625) Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com> * Use set_remap for if tag (autowarefoundation#1800) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Apply format (autowarefoundation#1999) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Fix cpplint Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Detection by tracker (autowarefoundation#1910) * initial commit * backup * apply format * cosmetic change * implement divided under segmenterd clusters * cosmetic change * bug fix * bug fix * bug fix * modify launch * add debug and bug fix * bug fix * bug fix * add no found tracked object * modify parameters and cmake * bug fix * remove debug info * add readme * modify clustering launch * run pre-commit * cosmetic change * cosmetic change * cosmetic change * apply markdownlint * modify launch * modify for cpplint * modify qos * change int to size_T * bug fix * change perception qos * Update perception/object_recognition/detection/detection_by_tracker/package.xml Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * cosmetic change * cosmetic change * fix launch * Update perception/object_recognition/detection/detection_by_tracker/src/utils.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * modify header include order * change include order * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * change to std::optional * cosmetic change * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * bug fix * modify readme Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * sync rc rc/v0.23.0 (autowarefoundation#2219) * Fix qos in roi cluster fusion (autowarefoundation#2218) * fix confidence (autowarefoundation#2220) Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * port roi cluster fusion (autowarefoundation#536) * remove COLCON_IGNORE * use DetectedObjectsWithFeature * fix topic type * update overwrite condition * add README of roi_cluster_fusion (autowarefoundation#653) * add README of roi_cluster_fusion * fix typo Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * add image Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Akihito Ohsato <aohsato@gmail.com> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: nik-tier4 <71747268+nik-tier4@users.noreply.github.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takamasa Horibe <takamasa.horib@gmail.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: pre-commit <pre-commit@example.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>

* release v0.4.0 * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "remove ROS1 packages temporarily" This reverts commit d6a59ac4c3762cb58ce6ca3e2cb31b3b8fc810ea. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Rename launch files to launch.xml (autowarefoundation#28) * Rename h files to hpp (autowarefoundation#142) * Change includes * Rename files * Adjustments to make things compile * Other packages * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * Port euclidean cluster (autowarefoundation#120) * porting CmakeLists.txt and package.xml in progress * ported CMakeLists.txt and package.xml to ROS2 * Ported euclidean_cluster from ROS1 to ROS2 * deleted unnecesary files * fixed transient_local Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Fix perception launches (autowarefoundation#240) * fix roi_cluster_fusion launch Signed-off-by: Takamasa Horibe <takamasa.horib@gmail.com> * add comment on launch Signed-off-by: Takamasa Horibe <takamasa.horib@gmail.com> Co-authored-by: Takamasa Horibe <takamasa.horib@gmail.com> * Ros2 v0.8.0 euclidean cluster (autowarefoundation#310) * restore euclidean cluster files for v0.8.0 update * fix typos in perception (autowarefoundation#862) * Feature/camera lidar perception (autowarefoundation#937) * add object splitter Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * add object merger Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * change pkg name Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * cosmetic change Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * add comment Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * remove litter Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * bug fix : debug code Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * enable vehicle to unknown track Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * bug fix * add object position in clustering * 🚮 * change param * fix name * bug fix * add install * Feature/fusion debug (autowarefoundation#1051) * add debuger * change param * add publisher * Revert "restore euclidean cluster files for v0.8.0 update" This reverts commit 894cb8746622b4eb88f2cf1b036cc8c94ab1ac96. * fix bug * use containter to launch nodelet * add line * [euclidean_cluster]: Fix launch python and CMakeLists.txt Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * add use_sim-time option (autowarefoundation#454) * Format launch files (autowarefoundation#1219) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Unify Apache-2.0 license name (autowarefoundation#1242) * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix lint errors (autowarefoundation#1378) * Fix lint errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix variable names Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Porting euclidean cluster (autowarefoundation#1291) * create config for euclidean cluster (autowarefoundation#1206) * create config * fix EOF * fix cmake list (autowarefoundation#1208) * Add load_composable_node_param Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Use tier4 voxel grid filter Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Refactor voxel grid based euclidean cluster launch Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix launch xml tag Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add missing arguments Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix pointcloud subscriber qos Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix dependency in CMakeLists.txt Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * Invoke code formatter at pre-commit (autowarefoundation#1935) * Run ament_uncrustify at pre-commit * Reformat existing files * Fix copyright and cpplint errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * Feature/clustering lib (autowarefoundation#1914) * change to lib for detection by tracking * refactor * apply format * Detection by tracker (autowarefoundation#1910) * initial commit * backup * apply format * cosmetic change * implement divided under segmenterd clusters * cosmetic change * bug fix * bug fix * bug fix * modify launch * add debug and bug fix * bug fix * bug fix * add no found tracked object * modify parameters and cmake * bug fix * remove debug info * add readme * modify clustering launch * run pre-commit * cosmetic change * cosmetic change * cosmetic change * apply markdownlint * modify launch * modify for cpplint * modify qos * change int to size_T * bug fix * change perception qos * Update perception/object_recognition/detection/detection_by_tracker/package.xml Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * cosmetic change * cosmetic change * fix launch * Update perception/object_recognition/detection/detection_by_tracker/src/utils.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * modify header include order * change include order * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * change to std::optional * cosmetic change * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * bug fix * modify readme Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * port euclidean_cluster (autowarefoundation#533) * delete COLCON_IGNORE * change dynamic_object_with_feature_array to detected_objects_with_feature * add classification * add classification.probability * add README of euclidean_cluster (autowarefoundation#614) * add README of euclidean_cluster * add period Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * update README Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * auto fix no ground pointcloud topic name (autowarefoundation#704) * fix/rename segmentation namespace (autowarefoundation#742) * rename segmentation directory * fix namespace: system stack * fix namespace: planning * fix namespace: control stack * fix namespace: perception stack * fix readme Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: nik-tier4 <71747268+nik-tier4@users.noreply.github.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takamasa Horibe <takamasa.horib@gmail.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Takeshi Ishita <ishitah.takeshi@gmail.com> Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>

* fix(behavior_velocity): fix dead lock condition Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore(behavior_velocity): unite valiable name to stop line Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix(behavior_velocity): fix dead lock condition of merge from private Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

…ion#240)

…arefoundation#2634) (autowarefoundation#240) * fix(system_error_monitor): hold emergency when timeout * fix: initialize other fault

…arefoundation#240) * delete_launch_planning_evaluator_arg Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * delete_launch_planning_evaluator_arg Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

taikitanaka3 requested a review from tkimura4 January 11, 2022 02:33

taikitanaka3 added the merge after porting label Jan 11, 2022

taikitanaka3 removed the merge after porting label Jan 17, 2022

taikitanaka3 marked this pull request as ready for review January 17, 2022 05:52

taikitanaka3 requested a review from 1222-takeshi January 17, 2022 06:11

taikitanaka3 force-pushed the 239-fix-behavior-velocity-deadlock branch from 7ddefbf to dd9023f Compare January 17, 2022 06:56

fix(behavior_velocity): fix dead lock condition

b950eac

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

taikitanaka3 force-pushed the 239-fix-behavior-velocity-deadlock branch from 72c8e00 to b950eac Compare January 25, 2022 00:42

yukkysaito reviewed Jan 25, 2022

View reviewed changes

planning/behavior_velocity_planner/src/scene_module/crosswalk/scene_walkway.cpp Outdated Show resolved Hide resolved

chore(behavior_velocity): unite valiable name to stop line

76c7ce9

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

taikitanaka3 closed this Jan 25, 2022

taikitanaka3 reopened this Jan 25, 2022

fix(behavior_velocity): fix dead lock condition of merge from private

abbf53a

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

tkimura4 approved these changes Jan 25, 2022

View reviewed changes

tkimura4 merged commit f49b3c2 into autowarefoundation:tier4/proposal Jan 25, 2022

taikitanaka3 mentioned this pull request Jan 28, 2022

consider case when autoware overshoot internally or externally #239

Closed

kenji-miyake mentioned this pull request Feb 8, 2022

chore: sync upstream tier4/autoware.universe#3

Merged

7 tasks

taikitanaka3 deleted the 239-fix-behavior-velocity-deadlock branch February 16, 2022 15:12

TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022

Add the description for CI checks to the PR template (autowarefoundat…

b5d370d

…ion#240)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(behavior_velocity): deadlock condition #240

fix(behavior_velocity): deadlock condition #240

taikitanaka3 commented Jan 11, 2022 •

edited

Loading

taikitanaka3 commented Jan 11, 2022 •

edited

Loading

taikitanaka3 commented Jan 25, 2022

tkimura4 left a comment

fix(behavior_velocity): deadlock condition #240

fix(behavior_velocity): deadlock condition #240

Conversation

taikitanaka3 commented Jan 11, 2022 • edited Loading

Related Issue(required)

Description(required)

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

Checklist for the PR Reviewer

Post-Review Checklist for the PR Author

CI Checks

taikitanaka3 commented Jan 11, 2022 • edited Loading

taikitanaka3 commented Jan 25, 2022

tkimura4 left a comment

Choose a reason for hiding this comment

taikitanaka3 commented Jan 11, 2022 •

edited

Loading

taikitanaka3 commented Jan 11, 2022 •

edited

Loading