-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(system_error_monitor): hold emergency when timeout happens #2634
fix(system_error_monitor): hold emergency when timeout happens #2634
Conversation
Codecov ReportBase: 11.47% // Head: 11.45% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2634 +/- ##
==========================================
- Coverage 11.47% 11.45% -0.02%
==========================================
Files 1272 1272
Lines 88535 88668 +133
Branches 23320 23320
==========================================
Hits 10161 10161
- Misses 67604 67737 +133
Partials 10770 10770
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…arefoundation#2634) * fix(system_error_monitor): hold emergency when timeout * fix: initialize other fault
…arefoundation#2634) (#240) * fix(system_error_monitor): hold emergency when timeout * fix: initialize other fault
Description
When timeout happens, emergency becomes true, but emergency_holding does not become true.
I'll fix it.
Related links
TIERIV_INTERNAL_LINK: https://tier4.atlassian.net/browse/T4PB-25040
Tests performed
use_emergency_hold
to true insystem.launch.xml
https://github.com/autowarefoundation/autoware.universe/blob/main/launch/tier4_system_launch/launch/system.launch.xml#L65
/system/emergency/hazard_status
ps -aux | grep default_ad_api | awk '{print $2}' | xargs kill
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.