Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(system_error_monitor): hold emergency when timeout happens #2634

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Jan 11, 2023

Description

When timeout happens, emergency becomes true, but emergency_holding does not become true.
I'll fix it.

Related links

TIERIV_INTERNAL_LINK: https://tier4.atlassian.net/browse/T4PB-25040

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Jan 11, 2023
@h-ohta h-ohta marked this pull request as ready for review January 11, 2023 08:36
@h-ohta h-ohta requested review from ito-san, kenji-miyake and a team as code owners January 11, 2023 08:36
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Base: 11.47% // Head: 11.45% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (756e411) compared to base (3522a10).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2634      +/-   ##
==========================================
- Coverage   11.47%   11.45%   -0.02%     
==========================================
  Files        1272     1272              
  Lines       88535    88668     +133     
  Branches    23320    23320              
==========================================
  Hits        10161    10161              
- Misses      67604    67737     +133     
  Partials    10770    10770              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.47% <0.00%> (ø) Carriedforward from 3522a10

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...or_path_planner/src/behavior_path_planner_node.cpp 0.17% <0.00%> (ø)
...path_planner/src/scene_module/lane_change/util.cpp 0.00% <0.00%> (ø)
...em_error_monitor/src/system_error_monitor_core.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-ohta h-ohta merged commit 99208eb into autowarefoundation:main Jan 12, 2023
h-ohta added a commit to tier4/autoware.universe that referenced this pull request Jan 12, 2023
…arefoundation#2634)

* fix(system_error_monitor): hold emergency when timeout

* fix: initialize other fault
yn-mrse pushed a commit to tier4/autoware.universe that referenced this pull request Jan 13, 2023
…arefoundation#2634) (#240)

* fix(system_error_monitor): hold emergency when timeout

* fix: initialize other fault
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants