-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lidar_centerpoint_tvm): add lidar centerpoint tvm package #2385
feat(lidar_centerpoint_tvm): add lidar centerpoint tvm package #2385
Conversation
FYI, I added my name to the maintainer's list since the author has be inactive for a while. The original PR has been approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original PR is approved so we can merged this once some spell-check issues are solved.
perception/lidar_centerpoint_tvm/include/lidar_centerpoint_tvm/centerpoint_config.hpp
Outdated
Show resolved
Hide resolved
Codecov ReportBase: 10.48% // Head: 10.48% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2385 +/- ##
=======================================
Coverage 10.48% 10.48%
=======================================
Files 1248 1248
Lines 91218 91218
Branches 21012 21012
=======================================
Hits 9565 9565
Misses 71466 71466
Partials 10187 10187
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
388c3fc
to
14ef2cc
Compare
…arefoundation#2385) * add centerpoint tvm Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp> * fixed typo in cmakelist and some formats Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp> Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…arefoundation#2385) * add centerpoint tvm Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp> * fixed typo in cmakelist and some formats Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp> Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: Xinyu Wang xinyu.wang@tier4.jp
Description
Reopen #1898 because the auther is inactive and the branch cannot be rebased.
Provide another lidar centerpoint package using the TVM inference engine compared to the original one using TensorRT inference engine. And this package's directory structure is consistent the original package.
Related links
Related issue #908
Tests performed
Tested locally.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.