Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lidar_centerpoint_tvm): add lidar centerpoint tvm package #2385

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

angry-crab
Copy link
Contributor

@angry-crab angry-crab commented Nov 28, 2022

Signed-off-by: Xinyu Wang xinyu.wang@tier4.jp

Description

Reopen #1898 because the auther is inactive and the branch cannot be rebased.
Provide another lidar centerpoint package using the TVM inference engine compared to the original one using TensorRT inference engine. And this package's directory structure is consistent the original package.

Related links

Related issue #908

Tests performed

Tested locally.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Nov 28, 2022
@angry-crab
Copy link
Contributor Author

angry-crab commented Nov 28, 2022

FYI, I added my name to the maintainer's list since the author has be inactive for a while. The original PR has been approved.

Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original PR is approved so we can merged this once some spell-check issues are solved.

perception/lidar_centerpoint_tvm/CMakeLists.txt Outdated Show resolved Hide resolved
perception/lidar_centerpoint_tvm/CMakeLists.txt Outdated Show resolved Hide resolved
perception/lidar_centerpoint_tvm/CMakeLists.txt Outdated Show resolved Hide resolved
perception/lidar_centerpoint_tvm/CMakeLists.txt Outdated Show resolved Hide resolved
perception/lidar_centerpoint_tvm/README.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 10.48% // Head: 10.48% // No change to project coverage 👍

Coverage data is based on head (388c3fc) compared to base (79fadf8).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 388c3fc differs from pull request most recent head 14ef2cc. Consider uploading reports for the commit 14ef2cc to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2385   +/-   ##
=======================================
  Coverage   10.48%   10.48%           
=======================================
  Files        1248     1248           
  Lines       91218    91218           
  Branches    21012    21012           
=======================================
  Hits         9565     9565           
  Misses      71466    71466           
  Partials    10187    10187           
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total 10.46% <0.00%> (ø) Carriedforward from 25fe6d2

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../behavior_path_planner/src/turn_signal_decider.cpp 35.93% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Xinyu Wang added 2 commits November 28, 2022 16:41
Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
@mitsudome-r mitsudome-r force-pushed the lidar_centerpoint_tvm branch from 388c3fc to 14ef2cc Compare November 28, 2022 07:41
@mitsudome-r mitsudome-r enabled auto-merge (squash) November 28, 2022 07:41
@mitsudome-r mitsudome-r merged commit 6ef6b54 into autowarefoundation:main Nov 28, 2022
@angry-crab angry-crab deleted the lidar_centerpoint_tvm branch November 28, 2022 07:58
@angry-crab angry-crab mentioned this pull request Dec 9, 2022
7 tasks
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…arefoundation#2385)

* add centerpoint tvm

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

* fixed typo in cmakelist and some formats

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…arefoundation#2385)

* add centerpoint tvm

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

* fixed typo in cmakelist and some formats

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants