-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tensorrt_yolox package #2370
Conversation
Now, all labels are treated as upper case
I think it's better to separate |
@wep21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
change format to autoware style |
@manato You should add your name to maintainer in package.xml. |
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
Codecov ReportBase: 10.45% // Head: 10.40% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2370 +/- ##
==========================================
- Coverage 10.45% 10.40% -0.06%
==========================================
Files 1253 1259 +6
Lines 91273 91714 +441
Branches 20935 20935
==========================================
Hits 9541 9541
- Misses 71593 72034 +441
Partials 10139 10139
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@miursh Also, the CI errors seem to be gone with the kind help of @yukke42 and @wep21 . I really appreciate their grateful support. |
* feat: clone tensorrt_yolox into autoware.universe * build: clone cuda_utils and tensorrt_common into lib * feat: support downloading pretrained model during build * fix: make label being case insensitive Now, all labels are treated as upper case * fix: support COCO-style label * docs: add README for tensorrt_yolox package * fix: remove pre-commit error * build: replace some boilerplate code by autoware_cmake * refactor: divide tensorrt_common and cuda_utils into separated packages * fix: add maintainer * fix: correct typo * use autoware lint common Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> Co-authored-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp> Co-authored-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
* feat: clone tensorrt_yolox into autoware.universe * build: clone cuda_utils and tensorrt_common into lib * feat: support downloading pretrained model during build * fix: make label being case insensitive Now, all labels are treated as upper case * fix: support COCO-style label * docs: add README for tensorrt_yolox package * fix: remove pre-commit error * build: replace some boilerplate code by autoware_cmake * refactor: divide tensorrt_common and cuda_utils into separated packages * fix: add maintainer * fix: correct typo * use autoware lint common Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> Co-authored-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp> Co-authored-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
* feat: clone tensorrt_yolox into autoware.universe * build: clone cuda_utils and tensorrt_common into lib * feat: support downloading pretrained model during build * fix: make label being case insensitive Now, all labels are treated as upper case * fix: support COCO-style label * docs: add README for tensorrt_yolox package * fix: remove pre-commit error * build: replace some boilerplate code by autoware_cmake * refactor: divide tensorrt_common and cuda_utils into separated packages * fix: add maintainer * fix: correct typo * use autoware lint common Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> Co-authored-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp> Co-authored-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp>
Description
This PR aims to add the
tensorrt_yolox
package into the series of perception modules in autoware.universe.The
tensorrt_yolox
package that works with autoware has been published in separated repository. This PR integrates the package's contents into autoware.universe.Related links
Tests performed
Notes for reviewers
I've added small modifications listed below from the original repository
PERSON
label in the same way as thePEDESTRIAN
label for COCO dataset compatibilityPre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.