Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] build-and-test-differential only tests CUDA #2409

Closed
3 tasks done
ambroise-arm opened this issue Nov 30, 2022 · 8 comments · Fixed by #2410
Closed
3 tasks done

[CI] build-and-test-differential only tests CUDA #2409

ambroise-arm opened this issue Nov 30, 2022 · 8 comments · Fixed by #2410
Labels
type:bug Software flaws or errors. type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:github-actions Github actions related. (auto-assigned)

Comments

@ambroise-arm
Copy link
Contributor

ambroise-arm commented Nov 30, 2022

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I'm convinced that this is not my fault but a bug.

Description

The build-and-test-differential workflow only starts a runner with cuda enabled:


This prevents catching issues on systems that don't have cuda enabled.
For example #2370 successfully passed CI, but failed once merged: https://github.com/autowarefoundation/autoware.universe/actions/runs/3583250712/jobs/6028456850

Expected behavior

CUDA shouldn't be required to build Autoware

Actual behavior

The CI for PRs doesn't check that.

Steps to reproduce

Build current tip of main (03de605) on a system without cuda.

Versions

No response

Possible causes

No response

Additional context

No response

@ambroise-arm ambroise-arm added type:bug Software flaws or errors. type:github-actions Github actions related. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Nov 30, 2022
@ambroise-arm
Copy link
Contributor Author

cc @kenji-miyake

@kenji-miyake
Copy link
Contributor

@ambroise-arm Actually, it was intentionally removed temporarily.
#1669

After we move to Humble and remove Galactic CI workflows by #2408, I believe we can re-enable no-cuda checks.

@kenji-miyake
Copy link
Contributor

kenji-miyake commented Nov 30, 2022

Ah, sorry. I might misunderstand your problem. Will fix my comment above.

@kenji-miyake
Copy link
Contributor

Okay, I think my comment wasn't so wrong.

CUDA shouldn't be required to build Autoware

I believe it's not true. We need CUDA for now because autoware.universe depends on CUDA yet.
But the no-cuda environment should also be tested.

@ambroise-arm What do you think?

@ambroise-arm
Copy link
Contributor Author

I believe your comment gives valuable information as it is.
Is the re-enablement of the no-cuda checks tracked somewhere? If not we could keep this open until it is done.

@kenji-miyake
Copy link
Contributor

I'll create a revert PR and relate this issue.

@ambroise-arm
Copy link
Contributor Author

ambroise-arm commented Nov 30, 2022

CUDA shouldn't be required to build Autoware

I believe it's not true.

I understand that cuda is necessary to have the runtime functionality of Autoware. But I strongly believe that it should be possible to built without it.
For example

has a different behavior whether cuda is present on the system or not, and doesn't fail if it's not.

I'll create a revert PR and relate this issue.

What about the problems from #1669, won't that just get us back to that?

EDIT: sorry, I hadn't seen #2410 (comment)

@kenji-miyake
Copy link
Contributor

But I strongly believe that it should be possible to built without it.

Yes, it's true! We gave up ensuring no-cuda just due to CI jams. Let's re-enable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Software flaws or errors. type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:github-actions Github actions related. (auto-assigned)
Projects
None yet
2 participants