-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] build-and-test-differential only tests CUDA #2409
Comments
@ambroise-arm Actually, it was intentionally removed temporarily. After we move to Humble and remove Galactic CI workflows by #2408, I believe we can re-enable no-cuda checks. |
Ah, sorry. I might misunderstand your problem. Will fix my comment above. |
Okay, I think my comment wasn't so wrong.
I believe it's not true. We need CUDA for now because @ambroise-arm What do you think? |
I believe your comment gives valuable information as it is. |
I'll create a revert PR and relate this issue. |
I understand that cuda is necessary to have the runtime functionality of Autoware. But I strongly believe that it should be possible to built without it.
What about the problems from #1669, won't that just get us back to that? EDIT: sorry, I hadn't seen #2410 (comment) |
Yes, it's true! We gave up ensuring no-cuda just due to CI jams. Let's re-enable it. |
Checklist
Description
The
build-and-test-differential
workflow only starts a runner with cuda enabled:autoware.universe/.github/workflows/build-and-test-differential.yaml
Line 17 in 03de605
This prevents catching issues on systems that don't have cuda enabled.
For example #2370 successfully passed CI, but failed once merged: https://github.com/autowarefoundation/autoware.universe/actions/runs/3583250712/jobs/6028456850
Expected behavior
CUDA shouldn't be required to build Autoware
Actual behavior
The CI for PRs doesn't check that.
Steps to reproduce
Build current tip of main (03de605) on a system without cuda.
Versions
No response
Possible causes
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: