Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: replace HADMap with Lanelet #2356

Merged
merged 7 commits into from
Nov 30, 2022
Merged

feat!: replace HADMap with Lanelet #2356

merged 7 commits into from
Nov 30, 2022

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Nov 23, 2022 •
edited
Loading

Signed-off-by: kosuke55 kosuke.tnp@gmail.com

Description

Replace HADMap of autoware_auto_planning_msg with Lanelet of autoware_planning_msgs.
LaneLetRoute has uuid and I want to use it in planning modules. Please refer to autowarefoundation/autoware#2983 for details.

Related links

Tests performed

psim

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) labels Nov 23, 2022
@kosuke55 kosuke55 changed the title feat: replace HADMap with Lanelet feat!: replace HADMap with Lanelet Nov 23, 2022
@kosuke55 kosuke55 force-pushed the feat/HADMap_to_Lanelet branch from 1aaf030 to c572b0b Compare November 23, 2022 14:06
This was referenced Nov 23, 2022
Merged
Merged
@kosuke55
Copy link
Contributor Author

this PR depends on autowarefoundation/autoware_common#133, so merge it first.

@yukkysaito
Copy link
Contributor

@kosuke55 Can you resolve some conflicts?

@isamu-takagi
Copy link
Contributor

@kosuke55 The ad_service_state_monitor package is replaced with AD API. So just remove it to resolve the conflict.

@isamu-takagi
Copy link
Contributor

@kosuke55 Sorry, config files need to be updated.

@kosuke55 kosuke55 force-pushed the feat/HADMap_to_Lanelet branch from c572b0b to 5dbc8a9 Compare November 29, 2022 04:46
@kosuke55
Copy link
Contributor Author

@isamu-takagi @yukkysaito
thanks, I resolved conflicts and updated the yaml.

@kosuke55
Copy link
Contributor Author

kosuke55 commented Nov 29, 2022 •
edited
Loading

oh, sorry build failed I will check it
-> ah, it's ok. "this PR depends on autowarefoundation/autoware_common#133, so merge it first."

isamu-takagi
isamu-takagi approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Checked it in the simple planning simulator.

yukkysaito
yukkysaito approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55
feat!: replace HADMap with Lanelet
07a4187 
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feat/HADMap_to_Lanelet branch from 5dbc8a9 to dfd9490 Compare November 30, 2022 01:47
@kosuke55 kosuke55 enabled auto-merge (squash) November 30, 2022 01:54
@mitsudome-r mitsudome-r disabled auto-merge November 30, 2022 02:10
kosuke55 and others added 6 commits November 30, 2022 11:17
@kosuke55
update topic.yaml
94be54f 
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 @wep21
Update perception/traffic_light_map_based_detector/README.md
45d0a37 
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 @wep21
Update planning/behavior_path_planner/README.md
978aef1 
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 @wep21
Update planning/mission_planner/README.md
696db31 
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 @wep21
Update planning/scenario_selector/README.md
b51acc4 
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55
format readme
434d6f8 
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feat/HADMap_to_Lanelet branch from 829c936 to 434d6f8 Compare November 30, 2022 02:17
@mitsudome-r mitsudome-r merged commit a790489 into autowarefoundation:main Nov 30, 2022
@mitsudome-r mitsudome-r deleted the feat/HADMap_to_Lanelet branch November 30, 2022 02:34
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Nov 30, 2022
Merged
@kosuke55 kosuke55 mentioned this pull request Nov 30, 2022
Merged
4 tasks
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
@kosuke55 @wep21 @HansRobo
feat!: replace HADMap with Lanelet (autowarefoundation#2356)
06ef38c 
* feat!: replace HADMap with Lanelet

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update topic.yaml

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update perception/traffic_light_map_based_detector/README.md

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/README.md

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/mission_planner/README.md

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/scenario_selector/README.md

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* format readme

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
@kosuke55 @wep21 @kminoda
feat!: replace HADMap with Lanelet (autowarefoundation#2356)
78c7356 
* feat!: replace HADMap with Lanelet

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update topic.yaml

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update perception/traffic_light_map_based_detector/README.md

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/README.md

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/mission_planner/README.md

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/scenario_selector/README.md

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* format readme

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wep21 wep21 wep21 left review comments

@isamu-takagi isamu-takagi isamu-takagi approved these changes

@yukkysaito yukkysaito yukkysaito approved these changes

@kenji-miyake kenji-miyake Awaiting requested review from kenji-miyake

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168

@rej55 rej55 Awaiting requested review from rej55

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota

@shmpwk shmpwk Awaiting requested review from shmpwk

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3

@tkimura4 tkimura4 Awaiting requested review from tkimura4

@purewater0901 purewater0901 Awaiting requested review from purewater0901

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4

@ito-san ito-san Awaiting requested review from ito-san ito-san is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara

@tkhmy tkhmy Awaiting requested review from tkhmy

@yabuta yabuta Awaiting requested review from yabuta

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kosuke55 @yukkysaito @isamu-takagi @wep21 @mitsudome-r