Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_avoidance_planner): parameterize non_fixed_trajectory_length #2349

Conversation

mehmetdogru
Copy link
Contributor

Signed-off-by: Mehmet Dogru 42mehmetdogru42@gmail.com

Description

This PR parameterize non_fixed_trajectory_length to be able to tune it easier.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ength

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
@mehmetdogru
Copy link
Contributor Author

@takayuki5168 to please review.

@github-actions github-actions bot added component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 10.48% // Head: 10.44% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (3f99726) compared to base (0b5c110).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2349      +/-   ##
==========================================
- Coverage   10.48%   10.44%   -0.04%     
==========================================
  Files        1251     1251              
  Lines       90903    91231     +328     
  Branches    20930    20930              
==========================================
  Hits         9527     9527              
- Misses      71237    71565     +328     
  Partials    10139    10139              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.45% <0.00%> (ø) Carriedforward from 0b5c110

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lude/obstacle_avoidance_planner/common_structs.hpp 0.00% <ø> (ø)
planning/obstacle_avoidance_planner/src/node.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mehmetdogru mehmetdogru added this to the Bus ODD Nov-Dec Milestone milestone Nov 22, 2022
@takayuki5168
Copy link
Contributor

Thanks for your contribution. I'll review this weekend.

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehmetdogru mehmetdogru merged commit aca3d67 into autowarefoundation:main Nov 28, 2022
@mehmetdogru mehmetdogru deleted the feat/parameterize-non_fixed_trajectory_length branch November 28, 2022 06:14
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…ength (autowarefoundation#2349)

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…ength (autowarefoundation#2349)

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants