-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(obstacle_avoidance_planner): parameterize non_fixed_trajectory_length #2349
feat(obstacle_avoidance_planner): parameterize non_fixed_trajectory_length #2349
Conversation
…ength Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
@takayuki5168 to please review. |
Codecov ReportBase: 10.48% // Head: 10.44% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2349 +/- ##
==========================================
- Coverage 10.48% 10.44% -0.04%
==========================================
Files 1251 1251
Lines 90903 91231 +328
Branches 20930 20930
==========================================
Hits 9527 9527
- Misses 71237 71565 +328
Partials 10139 10139
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Thanks for your contribution. I'll review this weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ength (autowarefoundation#2349) Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com> Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…ength (autowarefoundation#2349) Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com> Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com> Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: Mehmet Dogru 42mehmetdogru42@gmail.com
Description
This PR parameterize
non_fixed_trajectory_length
to be able to tune it easier.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.