-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_velocity_planner): parameterize ego_yield_query_stop_duration for crosswalk module #2346
Conversation
Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
Codecov ReportBase: 10.49% // Head: 11.23% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2346 +/- ##
==========================================
+ Coverage 10.49% 11.23% +0.73%
==========================================
Files 1251 1156 -95
Lines 90873 78525 -12348
Branches 20922 20596 -326
==========================================
- Hits 9537 8819 -718
+ Misses 71199 59938 -11261
+ Partials 10137 9768 -369
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you 👍
…ration for crosswalk module (autowarefoundation#2346) feat: parameterize ego_yield_query_stop_duration for crosswalk module Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com> Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…ration for crosswalk module (autowarefoundation#2346) feat: parameterize ego_yield_query_stop_duration for crosswalk module Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com> Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com> Signed-off-by: kminoda <koji.minoda@tier4.jp>
…ration for crosswalk module (autowarefoundation#2346) feat: parameterize ego_yield_query_stop_duration for crosswalk module Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com> Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: Mehmet Dogru 42mehmetdogru42@gmail.com
Description
This PR parameterize the duration to judge whether ego is yielding or not in crosswalk module.
Pre-review checklist for the PR author
The PR author must check the check boxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.