Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_planner): parameterize ego_yield_query_stop_duration for crosswalk module #2346

Conversation

mehmetdogru
Copy link
Contributor

@mehmetdogru mehmetdogru commented Nov 21, 2022

Signed-off-by: Mehmet Dogru 42mehmetdogru42@gmail.com

Description

This PR parameterize the duration to judge whether ego is yielding or not in crosswalk module.

Pre-review checklist for the PR author

The PR author must check the check boxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
@mehmetdogru mehmetdogru added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 21, 2022
@mehmetdogru mehmetdogru self-assigned this Nov 21, 2022
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Nov 21, 2022
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 10.49% // Head: 11.23% // Increases project coverage by +0.73% 🎉

Coverage data is based on head (8f41579) compared to base (12686e5).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2346      +/-   ##
==========================================
+ Coverage   10.49%   11.23%   +0.73%     
==========================================
  Files        1251     1156      -95     
  Lines       90873    78525   -12348     
  Branches    20922    20596     -326     
==========================================
- Hits         9537     8819     -718     
+ Misses      71199    59938   -11261     
+ Partials    10137     9768     -369     
Flag Coverage Δ *Carryforward flag
differential 4.20% <0.00%> (?)
total 11.29% <0.00%> (+0.82%) ⬆️ Carriedforward from 12686e5

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ity_planner/src/scene_module/crosswalk/manager.cpp 0.00% <0.00%> (ø)
...ner/src/scene_module/crosswalk/scene_crosswalk.cpp 0.00% <0.00%> (ø)
...ng_simulator/vehicle_model/sim_model_interface.hpp 0.00% <0.00%> (-66.67%) ⬇️
system/default_ad_api/src/interface.cpp 0.00% <0.00%> (-62.50%) ⬇️
system/default_ad_api/src/localization.cpp 0.00% <0.00%> (-37.50%) ⬇️
...auto_common/include/helper_functions/type_name.hpp 66.66% <0.00%> (-33.34%) ⬇️
..._utils/include/grid_map_utils/polygon_iterator.hpp 50.00% <0.00%> (-25.00%) ⬇️
...wer/include/trajectory_follower/lowpass_filter.hpp 50.00% <0.00%> (-25.00%) ⬇️
system/default_ad_api/src/operation_mode.cpp 0.00% <0.00%> (-24.10%) ⬇️
...mon/autoware_point_types/test/test_point_types.cpp 66.66% <0.00%> (-16.67%) ⬇️
... and 813 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you 👍

@mehmetdogru mehmetdogru merged commit 060c4cd into autowarefoundation:main Nov 22, 2022
@mehmetdogru mehmetdogru deleted the feat/parameterize-ego_yield_query_stop_duration-for-crosswalk-module branch November 22, 2022 02:50
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…ration for crosswalk module (autowarefoundation#2346)

feat: parameterize ego_yield_query_stop_duration for crosswalk module

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…ration for crosswalk module (autowarefoundation#2346)

feat: parameterize ego_yield_query_stop_duration for crosswalk module

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
…ration for crosswalk module (autowarefoundation#2346)

feat: parameterize ego_yield_query_stop_duration for crosswalk module

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants