Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(route_handler): add invert flag #2344

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Nov 21, 2022

Description

Add an invert flag to enable specific functions to invert opposite lanes when they get them.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901 purewater0901 requested review from rej55 and a team as code owners November 21, 2022 18:21
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 21, 2022
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 10.45% // Head: 10.43% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (9d1b799) compared to base (11ff8ef).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2344      +/-   ##
==========================================
- Coverage   10.45%   10.43%   -0.03%     
==========================================
  Files        1252     1252              
  Lines       91231    91421     +190     
  Branches    20922    21075     +153     
==========================================
  Hits         9537     9537              
- Misses      71557    71736     +179     
- Partials    10137    10148      +11     
Flag Coverage Δ *Carryforward flag
differential 3.34% <0.00%> (?)
total 10.42% <0.00%> (ø) Carriedforward from 11ff8ef

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/route_handler/src/route_handler.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rej55 rej55 merged commit 340f7bf into autowarefoundation:main Nov 22, 2022
@rej55 rej55 deleted the feat/add-invert-flag branch November 22, 2022 00:42
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
* feat(route_handler): add invert flag

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
* feat(route_handler): add invert flag

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
* feat(route_handler): add invert flag

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants