chore(motion_velocity_smoother): add debug print for non-supported function #2298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
github-actions
bot
added
the
component:planning
|
@mkuri Could you review this PR. |
Codecov ReportBase: 10.55% // Head: 10.53% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2298 +/- ##
==========================================
- Coverage 10.55% 10.53% -0.02%
==========================================
Files 1256 1256
Lines 91029 91191 +162
Branches 20790 20790
==========================================
Hits 9611 9611
- Misses 71260 71422 +162
Partials 10158 10158
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@rej55 Could you approve this PR. |
rej55
approved these changes
Nov 15, 2022
HansRobo
pushed a commit
to HansRobo/autoware.universe
that referenced
this pull request
Dec 16, 2022
…nction (autowarefoundation#2298) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Jan 6, 2023
…nction (autowarefoundation#2298) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: kminoda <koji.minoda@tier4.jp>
YoshiRi
pushed a commit
to YoshiRi/autoware.universe
that referenced
this pull request
Jan 11, 2023
…nction (autowarefoundation#2298) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
brkay54
pushed a commit
to vautonomous/autoware.universe
that referenced
this pull request
Jan 28, 2023
…nction (autowarefoundation#2298) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
voltonomous
added a commit
to vautonomous/autoware.universe
that referenced
this pull request
Jan 28, 2023
…tion#2157) Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com> chore: remove motion_common dependency (autowarefoundation#2231) * remove motion_common from smoother Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * remove motion_common from control_performance_analysis and simple_planning_simualtor Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix include Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * add include Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> refactor(motion_velocity_smoother): remove unused optional (autowarefoundation#1906) * remove unused optional Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * pre-commit Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> add tunable deccel limit before curve fix(motion_velocity_smoother): mismatch of v0/a0 between optimization and external velocity limit (autowarefoundation#2283) * fix(motion_velocity_smoother): inconsistent v0/a0 between optimization and external velocity limit Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * remove debug print Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> fix(motion_velocity_smoother): fix taking long time to start in "l2_smoother" (autowarefoundation#2289) fix-l2-smoother Signed-off-by: jack.song <jack.song@autocore.ai> Signed-off-by: jack.song <jack.song@autocore.ai> chore(motion_velocity_smoother): add debug print for non-supported function (autowarefoundation#2298) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> fix(motion_velocity_smoother): add current_closest_point_from_prev_output (autowarefoundation#2399) Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> increase distance before curve update delay compansation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Takayuki Murooka takayuki5168@gmail.com
Description
Without this PR, we don't know whether the external velocity limit calculation in motion_velocity_smoother is working well or not.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.