refactor(motion_common, motion_testing): remove packages #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
|
@TakaHoribe @maxime-clem Do you have any opinion on this PR? |
maxime-clem
approved these changes
Nov 12, 2022
There was a problem hiding this comment.
@TakaHoribe @maxime-clem Do you have any opinion on this PR?
🤩 It's beautiful.
TakaHoribe
approved these changes
Nov 14, 2022
github-actions
bot
added
component:common
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Jan 6, 2023
…ndation#2274) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: kminoda <koji.minoda@tier4.jp>
YoshiRi
pushed a commit
to YoshiRi/autoware.universe
that referenced
this pull request
Jan 11, 2023
…ndation#2274) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Takayuki Murooka takayuki5168@gmail.com
Description
In autoware.universe, motion_common package, which is autoware.auto's motion common package, is replaced with motion_utils
I'm working on removing motion_common's dependency on this issue.
#2229
If both motion_common and motion_utils exist, developers may use motion_common by mistake when developing some packages.
Therefore, I feel motion_common and its dependant motion_testing should be removed with this PR.
This PR has to be merged after all the motion_common's dependency in autoware.universe are removed .
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.