-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lidar_apollo_segmentation_tvm, tvm_utility): fixed output dim and pipeline #2185
Conversation
update bcnn has to be merged before this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the update of the model, the unit test of lidar_apollo_segmentaiton_tvm
doesn't pass anymore:
TEST(lidar_apollo_segmentation_tvm, runtime_error) { test_segmentation(false, false, true); } |
Which needs to become test_segmentation(false, false, false)
.
The comments won't make much sense then. Maybe you could put the 4 test_segmentation()
intensity/constant feature combinations in a single test group.
Codecov ReportBase: 10.55% // Head: 11.08% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2185 +/- ##
==========================================
+ Coverage 10.55% 11.08% +0.53%
==========================================
Files 1256 1212 -44
Lines 91029 86620 -4409
Branches 20790 20847 +57
==========================================
- Hits 9611 9606 -5
+ Misses 71260 66852 -4408
- Partials 10158 10162 +4
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ambroise-arm It seems that approving from reviewers with write access is required. Would you talk to @mitsudome-r about this? Thanks. |
@mitsudome-r This PR can be merged. |
@angry-crab can you rebase this PR? Auto-rebase warns of conflicts. |
Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
f16041b
to
328c2c2
Compare
Done! |
… pipeline (autowarefoundation#2185) Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
… pipeline (autowarefoundation#2185) Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp>
… pipeline (autowarefoundation#2185) Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: Xinyu Wang xinyu.wang@tier4.jp
Description
Resolve #1988
Changed default allocation device according to config. Fixed output data transfer in case of GPU involved.
Reason discussed in the follwing issue.
#1898
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.